Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.6 #189

Merged
merged 6 commits into from
Jul 20, 2021
Merged

v2.1.6 #189

merged 6 commits into from
Jul 20, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jul 9, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft July 9, 2021 03:58
@RobH123 RobH123 linked an issue Jul 9, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Jul 12, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #189 (071bb99) into master (7ba891d) will decrease coverage by 0.52%.
The diff coverage is 12.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
- Coverage   36.48%   35.95%   -0.53%     
==========================================
  Files          27       28       +1     
  Lines        3670     3721      +51     
  Branches     1381     1399      +18     
==========================================
- Hits         1339     1338       -1     
- Misses       1382     1415      +33     
- Partials      949      968      +19     
Impacted Files Coverage Δ
src/core/defaults.js 100.00% <ø> (ø)
src/core/getApi.js 20.10% <0.00%> (ø)
src/core/manifest-text-check.js 4.21% <0.00%> (ø)
src/core/notes-tsv7-row-check.js 68.42% <ø> (-0.19%) ⬇️
src/core/lexicon-file-contents-check.js 2.04% <2.04%> (ø)
src/core/orig-quote-check.js 60.39% <50.00%> (-0.92%) ⬇️
src/core/utilities.js 29.03% <66.66%> (-3.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ba891d...071bb99. Read the comment docs.

@RobH123 RobH123 requested a review from mandolyte July 16, 2021 02:24
@RobH123 RobH123 marked this pull request as ready for review July 16, 2021 02:37
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 23 files at r1, 22 of 22 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 081a79f into master Jul 20, 2021
@mandolyte mandolyte deleted the new.2021.July branch July 20, 2021 11:29
@RobH123 RobH123 changed the title New.2021.july V2.1.6 Jul 20, 2021
@RobH123 RobH123 changed the title V2.1.6 v2.1.6 Jul 20, 2021
@mandolyte
Copy link
Contributor

Will disconnect from issue since v2.1.7 is now available. We can skip this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3JN BP check seems to find extra SQ quote errors Improve WARNINGS SUPPRESSED in demos
2 participants