Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.7 checking consistency of alignment details copied into ULT/UST from UHB/UGNT #198

Merged
merged 4 commits into from
Jul 28, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jul 20, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft July 20, 2021 22:29
@RobH123 RobH123 linked an issue Jul 20, 2021 that may be closed by this pull request
@RobH123 RobH123 requested a review from mandolyte July 21, 2021 09:47
@RobH123 RobH123 marked this pull request as ready for review July 21, 2021 09:47
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #198 (7bad24b) into master (081a79f) will increase coverage by 0.66%.
The diff coverage is 58.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #198      +/-   ##
==========================================
+ Coverage   35.95%   36.62%   +0.66%     
==========================================
  Files          28       28              
  Lines        3721     3806      +85     
  Branches     1399     1425      +26     
==========================================
+ Hits         1338     1394      +56     
- Misses       1415     1428      +13     
- Partials      968      984      +16     
Impacted Files Coverage Δ
src/core/manifest-text-check.js 4.21% <0.00%> (ø)
src/core/questions-tsv7-row-check.js 2.95% <0.00%> (ø)
src/core/text-handling-functions.js 89.65% <0.00%> (-3.21%) ⬇️
src/core/tn-tsv9-row-check.js 63.47% <0.00%> (ø)
src/core/twl-tsv6-row-check.js 3.12% <0.00%> (ø)
src/core/notes-tsv7-row-check.js 68.42% <33.33%> (ø)
src/core/orig-quote-check.js 59.80% <33.33%> (-0.60%) ⬇️
src/core/field-text-check.js 50.42% <50.00%> (ø)
src/core/usfm-text-check.js 54.11% <63.02%> (+1.98%) ⬆️
src/core/notes-links-check.js 25.38% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081a79f...7bad24b. Read the comment docs.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit e405770 into master Jul 28, 2021
@mandolyte mandolyte deleted the new.2021.July.2 branch July 28, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check alignment data against original
2 participants