-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.2 #200
Version 2.2 #200
Conversation
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 36.62% 30.19% -6.44%
==========================================
Files 28 29 +1
Lines 3806 4163 +357
Branches 1425 1525 +100
==========================================
- Hits 1394 1257 -137
- Misses 1428 1770 +342
- Partials 984 1136 +152
Continue to review full report at Codecov.
|
Well, turned out bigger than expected/wanted again because it included a bug fix to do with occurrence numbers. But basically it improves TN and OBS and Hebrew Unicode checks, as well as adding lexicon checks for the first time @mandolyte. Please note @ancientTexts-net also, that the hundreds of lexicon look-ups do slow down some checks x10. If you find that using this version affects your calls, please include "disableLexiconLinkFetchingFlag: true" in the options that you pass in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 47 files at r1, 34 of 34 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @RobH123)
This change is