Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.2 #200

Merged
merged 14 commits into from
Aug 12, 2021
Merged

Version 2.2 #200

merged 14 commits into from
Aug 12, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Jul 28, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft July 28, 2021 19:51
@RobH123 RobH123 linked an issue Jul 28, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Aug 3, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 3, 2021

Codecov Report

Merging #200 (295d352) into master (e405770) will decrease coverage by 6.43%.
The diff coverage is 17.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #200      +/-   ##
==========================================
- Coverage   36.62%   30.19%   -6.44%     
==========================================
  Files          28       29       +1     
  Lines        3806     4163     +357     
  Branches     1425     1525     +100     
==========================================
- Hits         1394     1257     -137     
- Misses       1428     1770     +342     
- Partials      984     1136     +152     
Impacted Files Coverage Δ
src/core/BCS-usfm-grammar-check.js 25.92% <0.00%> (ø)
src/core/disabled-notices.js 72.22% <ø> (ø)
src/core/manifest-text-check.js 4.21% <ø> (ø)
src/core/notes-tsv7-table-check.js 2.54% <0.00%> (ø)
src/core/questions-tsv7-row-check.js 2.95% <0.00%> (ø)
src/core/questions-tsv7-table-check.js 2.54% <0.00%> (ø)
src/core/ta-reference-check.js 0.00% <0.00%> (-90.91%) ⬇️
src/core/twl-tsv6-row-check.js 3.12% <0.00%> (ø)
src/core/twl-tsv6-table-check.js 2.54% <0.00%> (ø)
src/core/usfm-js-check.js 23.52% <0.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e405770...295d352. Read the comment docs.

@RobH123 RobH123 marked this pull request as ready for review August 12, 2021 06:08
@RobH123 RobH123 changed the title Version 2.2 maybe Version 2.2 Aug 12, 2021
@RobH123 RobH123 requested a review from mandolyte August 12, 2021 06:10
@RobH123
Copy link
Contributor Author

RobH123 commented Aug 12, 2021

Well, turned out bigger than expected/wanted again because it included a bug fix to do with occurrence numbers. But basically it improves TN and OBS and Hebrew Unicode checks, as well as adding lexicon checks for the first time @mandolyte.

Please note @ancientTexts-net also, that the hundreds of lexicon look-ups do slow down some checks x10. If you find that using this version affects your calls, please include "disableLexiconLinkFetchingFlag: true" in the options that you pass in.

This was linked to issues Aug 12, 2021
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 47 files at r1, 34 of 34 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit a4a222b into master Aug 12, 2021
@mandolyte mandolyte deleted the new.2021.July.3 branch August 12, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants