Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.2.1 #205

Merged
merged 11 commits into from
Sep 1, 2021
Merged

Version 2.2.1 #205

merged 11 commits into from
Sep 1, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Aug 17, 2021

Fix bugs in matching words, especially with occurrence > 1. This removes some false alarms.


This change is Reviewable

@RobH123 RobH123 requested a review from mandolyte August 17, 2021 10:10
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #205 (c696aa8) into master (a4a222b) will decrease coverage by 0.14%.
The diff coverage is 31.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   30.19%   30.05%   -0.15%     
==========================================
  Files          29       29              
  Lines        4163     4279     +116     
  Branches     1525     1583      +58     
==========================================
+ Hits         1257     1286      +29     
- Misses       1770     1817      +47     
- Partials     1136     1176      +40     
Impacted Files Coverage Δ
src/core/defaults.js 100.00% <ø> (ø)
src/core/strongs-field-check.js 27.65% <0.00%> (ø)
src/core/ta-reference-check.js 0.00% <ø> (ø)
src/core/tn-tsv9-row-check.js 59.88% <ø> (ø)
src/core/notes-tsv7-table-check.js 2.30% <5.00%> (-0.24%) ⬇️
src/core/orig-quote-check.js 11.15% <5.21%> (+1.15%) ⬆️
src/core/questions-tsv7-table-check.js 2.30% <5.26%> (-0.24%) ⬇️
src/core/twl-tsv6-table-check.js 2.30% <5.26%> (-0.24%) ⬇️
src/core/yaml-text-check.js 2.32% <33.33%> (ø)
src/core/usfm-text-check.js 45.59% <41.17%> (+0.03%) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4a222b...c696aa8. Read the comment docs.

@RobH123 RobH123 removed the request for review from mandolyte August 17, 2021 10:30
@RobH123 RobH123 marked this pull request as draft August 17, 2021 10:30
@ancientTexts-net
Copy link
Contributor

@RobH123 says:

I have discovered that CV 2.2.0 (with rewritten quote-portion matching code (to try to match more closely what tC appears to do) is giving a couple of false alarms, so I suggest waiting for 2.2.1 which I'm working on.

CC: @mandolyte @birchamp @BincyJ

@RobH123 RobH123 requested a review from mandolyte August 30, 2021 08:18
@RobH123 RobH123 marked this pull request as ready for review August 30, 2021 08:23
@RobH123
Copy link
Contributor Author

RobH123 commented Aug 30, 2021

Sorry, again I wasn't intending to do all of this stuff, but then I needed to add or fix or fine-tune checks for my content work and improve the "demos" that I use as my main "workhorse", and so it grows... Anyway, it should be ready to use in tCC now hopefully.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r1, 1 of 13 files at r2, 44 of 44 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 9f22465 into master Sep 1, 2021
@mandolyte mandolyte deleted the new.2021.August branch September 1, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants