Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with repoCode for linked articles; add test for newLine in TN single line field that crashed tC build #206

Merged
merged 4 commits into from
Sep 3, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Sep 1, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft September 1, 2021 22:26
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #206 (1a81779) into master (9f22465) will decrease coverage by 0.02%.
The diff coverage is 31.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   30.05%   30.02%   -0.03%     
==========================================
  Files          29       29              
  Lines        4279     4339      +60     
  Branches     1583     1616      +33     
==========================================
+ Hits         1286     1303      +17     
- Misses       1817     1835      +18     
- Partials     1176     1201      +25     
Impacted Files Coverage Δ
src/core/questions-tsv7-row-check.js 2.77% <0.00%> (-0.19%) ⬇️
src/core/twl-tsv6-row-check.js 2.90% <0.00%> (-0.22%) ⬇️
src/core/notes-links-check.js 20.76% <13.04%> (-0.10%) ⬇️
src/core/notes-tsv7-row-check.js 62.70% <53.33%> (-1.04%) ⬇️
src/core/tn-tsv9-row-check.js 59.55% <62.50%> (-0.33%) ⬇️
src/core/markdown-file-contents-check.js 38.88% <66.66%> (+0.31%) ⬆️
src/core/markdown-text-check.js 56.29% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f22465...1a81779. Read the comment docs.

@RobH123 RobH123 changed the title WIP debugging identification of linked TA & TW articles Fix bug with repoCode for linked articles; add test for newLine in TN single line field that crashed tC build Sep 3, 2021
@RobH123 RobH123 marked this pull request as ready for review September 3, 2021 03:27
@RobH123 RobH123 requested a review from mandolyte September 3, 2021 03:28
@RobH123
Copy link
Contributor Author

RobH123 commented Sep 3, 2021

A small one this time with one bug fix and one new check.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 14 of 14 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 19ae13c into master Sep 3, 2021
@mandolyte mandolyte deleted the new.2021.September branch September 3, 2021 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants