Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.2.5 #216

Merged
merged 13 commits into from
Sep 28, 2021
Merged

Version 2.2.5 #216

merged 13 commits into from
Sep 28, 2021

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Sep 24, 2021

A number of improvements resulting from runnning checks on our English repos


This change is Reviewable

@RobH123 RobH123 requested a review from mandolyte September 24, 2021 02:23
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #216 (0672f4c) into master (19ae13c) will decrease coverage by 0.14%.
The diff coverage is 34.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
- Coverage   30.02%   29.88%   -0.15%     
==========================================
  Files          29       29              
  Lines        4339     4297      -42     
  Branches     1616     1632      +16     
==========================================
- Hits         1303     1284      -19     
+ Misses       1835     1800      -35     
- Partials     1201     1213      +12     
Impacted Files Coverage Δ
src/core/field-link-check.js 0.00% <0.00%> (ø)
src/core/file-text-check.js 78.57% <0.00%> (ø)
src/core/lexicon-file-contents-check.js 2.50% <0.00%> (+0.93%) ⬆️
src/core/manifest-text-check.js 4.21% <0.00%> (ø)
src/core/notes-tsv7-table-check.js 2.30% <0.00%> (ø)
src/core/questions-tsv7-row-check.js 2.74% <0.00%> (-0.04%) ⬇️
src/core/questions-tsv7-table-check.js 2.30% <0.00%> (ø)
src/core/ta-reference-check.js 0.00% <0.00%> (ø)
src/core/tn-tsv9-table-check.js 60.50% <0.00%> (ø)
src/core/twl-tsv6-row-check.js 2.89% <0.00%> (-0.02%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ae13c...0672f4c. Read the comment docs.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 53 of 53 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 63703f1 into master Sep 28, 2021
@mandolyte mandolyte deleted the new.2021.September.4 branch September 28, 2021 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants