Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.1 with various small fixes and improvements #229

Merged
merged 27 commits into from
Dec 10, 2021
Merged

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Nov 7, 2021

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft November 7, 2021 22:43
@RobH123 RobH123 linked an issue Nov 7, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 8, 2021

Codecov Report

Merging #229 (48efeeb) into master (2cb0ce8) will increase coverage by 0.39%.
The diff coverage is 34.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   40.00%   40.40%   +0.39%     
==========================================
  Files          30       31       +1     
  Lines        4504     4616     +112     
  Branches     1728     1765      +37     
==========================================
+ Hits         1802     1865      +63     
- Misses       1643     1644       +1     
- Partials     1059     1107      +48     
Impacted Files Coverage Δ
src/core/orig-quote-check.js 10.74% <0.00%> (-0.33%) ⬇️
src/core/questions-tsv7-row-check.js 49.19% <0.00%> (ø)
src/core/twl-tsv6-row-check.js 52.87% <0.00%> (ø)
src/core/usfm-text-check.js 44.21% <16.80%> (-0.35%) ⬇️
src/core/getApi.js 15.92% <19.35%> (+0.01%) ⬆️
src/core/questions-tsv7-table-check.js 55.30% <20.00%> (ø)
src/core/notes-tsv7-table-check.js 55.03% <25.00%> (ø)
src/core/tn-tsv9-table-check.js 60.16% <25.00%> (ø)
src/core/twl-tsv6-table-check.js 57.36% <25.00%> (ø)
src/core/markdown-text-check.js 57.85% <42.85%> (-1.10%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cb0ce8...48efeeb. Read the comment docs.

@RobH123 RobH123 linked an issue Nov 10, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Nov 10, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Nov 17, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Nov 17, 2021 that may be closed by this pull request
@RobH123 RobH123 linked an issue Nov 19, 2021 that may be closed by this pull request
@RobH123 RobH123 mentioned this pull request Dec 9, 2021
@RobH123 RobH123 changed the title Potential v3.0.1 v3.1 with various small fixes and improvements Dec 10, 2021
@RobH123
Copy link
Contributor Author

RobH123 commented Dec 10, 2021

Updated to v3.1 because of the number of updates.

@RobH123 RobH123 marked this pull request as ready for review December 10, 2021 03:31
@RobH123 RobH123 requested a review from mandolyte December 10, 2021 03:31
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 30 files at r1, 35 of 35 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RobH123)

@mandolyte mandolyte merged commit 1cba819 into master Dec 10, 2021
@mandolyte mandolyte deleted the new.2021.November branch December 10, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants