Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various improvements #31

Merged
merged 8 commits into from
Sep 15, 2020
Merged

Various improvements #31

merged 8 commits into from
Sep 15, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Sep 13, 2020

No description provided.

@RobH123 RobH123 changed the title Rj himprovements Various small improvements Sep 13, 2020
@RobH123
Copy link
Contributor Author

RobH123 commented Sep 14, 2020

Well, this started off with small fixes to details of the checks, but some checks added after working with JoelR last week, led to adding an optional details field to some notices. I didn't want to change the API again, but decided to go ahead since I don't think @mandolyte had incorporated previous updates yet anyway.

@RobH123 RobH123 changed the title Various small improvements Various improvements Sep 14, 2020
@RobH123
Copy link
Contributor Author

RobH123 commented Sep 15, 2020

Pls feel free to merge this @PhotoNomad0 if it looks ok. Also ok to publish to NPM AFAIK.

BTW, did you do some work on testing caching? Even after clearing caches, I still seem to have trouble getting the latest TN file from D43 to check.

@RobH123 RobH123 merged commit 4d150ab into master Sep 15, 2020
@RobH123 RobH123 deleted the RJHimprovements branch September 15, 2020 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant