Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add unit tests #40

Merged
merged 32 commits into from
Sep 22, 2020
Merged

Feature/add unit tests #40

merged 32 commits into from
Sep 22, 2020

Conversation

PhotoNomad0
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 commented Sep 18, 2020 •
edited
Loading

  • added unit tests for checkTN_TSVDataRow() and checkBookPackage()
  • updated github actions to run unit tests and update code coverage

This change is Reviewable

@PhotoNomad0
added unit tests and fixtures
193bb45
@PhotoNomad0
added unit tests and fixtures
e987ae4
@PhotoNomad0
added unit tests and fixtures
eec4a33
@PhotoNomad0
tweaks
3b4a71c
@PhotoNomad0
added more tests
5f06f1a
@PhotoNomad0
Merge branch 'feature-mcleanb-addCacheControl' into feature-mcleanb-a…
1e12e30 
…ddUnitTests
@PhotoNomad0
merged with Roberts latest and updated snapshots
d566cd8
@PhotoNomad0
Merge branch 'master' of https://github.com/unfoldingWord/content-val…
13838bb 
…idation-rcl into feature-mcleanb-addUnitTests
@PhotoNomad0
merged with Roberts latest and updated snapshots
95daa9d
@PhotoNomad0
Merge branch 'master' of https://github.com/unfoldingWord/content-val…
631e46a 
…idation-rcl into feature-mcleanb-addUnitTests
@PhotoNomad0
fix unit tests after update with master.
9876c20
@PhotoNomad0
adding tests for checkBookPackage()
9733ce7
@PhotoNomad0
adding tests for checkBookPackage()
ae1fe16
@PhotoNomad0
adding tests for checkTN_TSVDataRow()
158b6ad
@PhotoNomad0
fix case in checkBookPackage() where it was using the old checkingOpt…
cc5f056 
…ions() instead of the newCheckingOptions.
@PhotoNomad0
adding travis for unit tests
7a84794
@PhotoNomad0
adding github action for unit tests
8471edb
@PhotoNomad0
fixes to run jest unit tests
7348f90
@PhotoNomad0
disble cypress tests
cf8e3e4
@PhotoNomad0
comments
e95f3ab
@PhotoNomad0
Merge branch 'master' of https://github.com/unfoldingWord/content-val…
bf76335 
…idation-rcl into feature-mcleanb-addUnitTests

� Conflicts:
�	src/core/book-package-check.js
�	src/core/getApi.js
@PhotoNomad0
cleanup after merging latest master
64f4224
@PhotoNomad0
fix code coverage
0559508
@codecov
Copy link

codecov bot commented Sep 21, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5841a21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #40   +/-   ##
=========================================
  Coverage          ?   45.34%           
=========================================
  Files             ?       21           
  Lines             ?     2064           
  Branches          ?      594           
=========================================
  Hits              ?      936           
  Misses            ?      742           
  Partials          ?      386

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5841a21...f0e623d. Read the comment docs.

@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review September 22, 2020 12:51
RobH123
RobH123 previously approved these changes Sep 22, 2020
View reviewed changes
@RobH123 RobH123 merged commit 702c8e5 into master Sep 22, 2020
@RobH123 RobH123 deleted the feature-mcleanb-addUnitTests branch September 22, 2020 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobH123 RobH123 RobH123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhotoNomad0 @RobH123