Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix exports to work from importing app #49

Merged
merged 3 commits into from
Sep 24, 2020
Merged

Conversation

mandolyte
Copy link
Contributor

@mandolyte mandolyte commented Sep 24, 2020

This change is Reviewable

@mandolyte mandolyte self-assigned this Sep 24, 2020
RobH123
RobH123 previously approved these changes Sep 24, 2020
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #49 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   45.34%   45.34%           
=======================================
  Files          21       21           
  Lines        2064     2064           
  Branches      594      594           
=======================================
  Hits          936      936           
  Misses        742      742           
  Partials      386      386           
Impacted Files Coverage Δ
src/core/BCS-usfm-grammar-check.js 55.26% <ø> (ø)
src/core/annotation-row-check.js 0.00% <ø> (ø)
src/core/annotation-table-check.js 0.00% <ø> (ø)
src/core/book-package-check.js 52.70% <ø> (ø)
src/core/field-link-check.js 0.00% <ø> (ø)
src/core/field-text-check.js 59.82% <ø> (ø)
src/core/file-text-check.js 53.19% <ø> (ø)
src/core/manifest-text-check.js 4.25% <ø> (ø)
src/core/markdown-text-check.js 81.81% <ø> (ø)
src/core/plain-text-check.js 4.65% <ø> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 702c8e5...7a98dbf. Read the comment docs.

@mandolyte mandolyte merged commit 0161379 into master Sep 24, 2020
@RobH123 RobH123 deleted the bugfix-cn-fix-exports branch September 24, 2020 21:48
@RobH123 RobH123 linked an issue Sep 25, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Core functions not recognized as functions on import
2 participants