Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move stuff back out of core and of NPM #52

Merged
merged 4 commits into from
Sep 30, 2020
Merged

Move stuff back out of core and of NPM #52

merged 4 commits into from
Sep 30, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Sep 29, 2020

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft September 29, 2020 00:42
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #52 into master will increase coverage by 3.45%.
The diff coverage is 68.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   48.61%   52.06%   +3.45%     
==========================================
  Files          21       20       -1     
  Lines        2236     1961     -275     
  Branches      653      614      -39     
==========================================
- Hits         1087     1021      -66     
+ Misses        729      569     -160     
+ Partials      420      371      -49     
Impacted Files Coverage Δ
src/core/annotation-row-check.js 1.88% <0.00%> (+1.88%) ⬆️
src/core/getApi.js 10.52% <0.00%> (-0.29%) ⬇️
src/core/manifest-text-check.js 59.57% <ø> (+55.31%) ⬆️
src/core/quote-check.js 69.81% <0.00%> (ø)
src/core/usfm-text-check.js 58.04% <0.00%> (ø)
src/core/tn-table-row-check.js 75.59% <61.76%> (ø)
src/core/field-text-check.js 55.65% <66.66%> (+0.78%) ⬆️
src/core/markdown-text-check.js 81.81% <69.23%> (ø)
src/core/tn-links-check.js 86.79% <80.70%> (+6.20%) ⬆️
src/core/ta-reference-check.js 95.55% <96.96%> (+0.10%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd38838...49d71c0. Read the comment docs.

@RobH123 RobH123 marked this pull request as ready for review September 30, 2020 08:35
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 39 of 39 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@RobH123 RobH123 merged commit 860cb05 into master Sep 30, 2020
@RobH123 RobH123 deleted the RJHimprovements branch September 30, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants