Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve USFM and TN link checking, etc. #55

Merged
merged 13 commits into from
Oct 6, 2020
Merged

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Oct 1, 2020

This change is Reviewable

@RobH123 RobH123 changed the title Rj himprovements Improve fetching and checks Oct 1, 2020
@RobH123 RobH123 linked an issue Oct 1, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #55 into master will decrease coverage by 4.19%.
The diff coverage is 30.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   52.06%   47.87%   -4.20%     
==========================================
  Files          20       20              
  Lines        1961     2047      +86     
  Branches      614      643      +29     
==========================================
- Hits         1021      980      -41     
- Misses        569      666      +97     
- Partials      371      401      +30     
Impacted Files Coverage Δ
src/core/getApi.js 10.12% <0.00%> (-0.40%) ⬇️
src/core/markdown-text-check.js 81.81% <ø> (ø)
src/core/text-handling-functions.js 91.30% <0.00%> (+13.04%) ⬆️
src/core/manifest-text-check.js 10.20% <19.04%> (-49.38%) ⬇️
src/core/tn-links-check.js 69.34% <21.95%> (-17.45%) ⬇️
src/core/usfm-text-check.js 58.10% <33.33%> (+0.06%) ⬆️
src/core/tn-table-row-check.js 70.61% <47.05%> (-4.98%) ⬇️
src/core/ta-reference-check.js 95.55% <50.00%> (ø)
src/core/tn-table-text-check.js 64.60% <56.00%> (-5.51%) ⬇️
src/core/field-text-check.js 54.70% <66.66%> (-0.96%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49d71c0...96a1945. Read the comment docs.

@RobH123 RobH123 requested a review from PhotoNomad0 October 2, 2020 03:18
PhotoNomad0
PhotoNomad0 previously approved these changes Oct 6, 2020
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 10 files at r1, 31 of 31 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@RobH123 RobH123 changed the title Improve fetching and checks Improve USFM and TN link checking, etc. Oct 6, 2020
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PhotoNomad0 PhotoNomad0 merged commit 0d810ba into master Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation notices on empty support references
2 participants