-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tighten TA ref checks in TN as per Perry Oakes spec #56
Conversation
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
==========================================
+ Coverage 47.87% 47.93% +0.05%
==========================================
Files 20 20
Lines 2047 2055 +8
Branches 643 646 +3
==========================================
+ Hits 980 985 +5
Misses 666 666
- Partials 401 404 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 9 of 9 files at r1.
Reviewable status: complete! all files reviewed, all discussions resolved
@RobH123 It looks like this is ready to go except for version. Published as |
@RobH123 it looks like you should probably add |
@RobH123 Also you can cut test time in half by changing the jest configuration section in package.json to be:
Unfortunately it is copying all the tests to ./dist folder and so they get run twice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
As specified on Zulip in wg-content / Writing tNotes
This change is