Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten TA ref checks in TN as per Perry Oakes spec #56

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Oct 7, 2020

As specified on Zulip in wg-content / Writing tNotes


This change is Reviewable

@RobH123 RobH123 requested a review from PhotoNomad0 October 7, 2020 03:31
@RobH123 RobH123 added the enhancement New feature or request label Oct 7, 2020
@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.05%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   47.87%   47.93%   +0.05%     
==========================================
  Files          20       20              
  Lines        2047     2055       +8     
  Branches      643      646       +3     
==========================================
+ Hits          980      985       +5     
  Misses        666      666              
- Partials      401      404       +3     
Impacted Files Coverage Δ
src/core/tn-table-row-check.js 70.29% <62.50%> (-0.33%) ⬇️
src/core/tn-links-check.js 69.34% <76.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d810ba...d544478. Read the comment docs.

PhotoNomad0
PhotoNomad0 previously approved these changes Oct 7, 2020
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PhotoNomad0
Copy link
Contributor

@RobH123 It looks like this is ready to go except for version. Published as 0.8.15-alpha.1 for testing.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Oct 7, 2020

@RobH123 it looks like you should probably add ./dist/__tests__/ to .npmignore. Looks like that is the source of extra files in your npm modules.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Oct 7, 2020

@RobH123 Also you can cut test time in half by changing the jest configuration section in package.json to be:

  "jest": {
    "collectCoverageFrom": [
      "src/core/**.{js,jsx,ts}",
      "!**/node_modules/**",
      "!**/vendor/**"
    ],
    "modulePathIgnorePatterns": ["<rootDir>/dist/"]
  }

Unfortunately it is copying all the tests to ./dist folder and so they get run twice.

Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@PhotoNomad0 PhotoNomad0 merged commit a10e477 into master Oct 7, 2020
@PhotoNomad0 PhotoNomad0 deleted the RJHimprovements branch October 7, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants