Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get annotation checks working, plus some small fixes #57

Merged
merged 9 commits into from
Oct 16, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Oct 8, 2020

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft October 8, 2020 20:23
@codecov
Copy link

codecov bot commented Oct 8, 2020

Codecov Report

Merging #57 into master will decrease coverage by 1.74%.
The diff coverage is 28.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   47.93%   46.18%   -1.75%     
==========================================
  Files          20       20              
  Lines        2055     2217     +162     
  Branches      646      708      +62     
==========================================
+ Hits          985     1024      +39     
- Misses        666      732      +66     
- Partials      404      461      +57     
Impacted Files Coverage Δ
src/core/annotation-table-check.js 3.22% <0.00%> (-1.13%) ⬇️
src/core/manifest-text-check.js 10.41% <ø> (+0.21%) ⬆️
src/core/yaml-text-check.js 4.08% <ø> (ø)
src/core/annotation-row-check.js 1.94% <1.96%> (+0.05%) ⬆️
src/core/getApi.js 10.65% <21.42%> (+0.52%) ⬆️
src/core/ta-reference-check.js 89.79% <37.50%> (-5.76%) ⬇️
src/core/tn-table-text-check.js 67.47% <52.50%> (+2.87%) ⬆️
src/core/usfm-text-check.js 58.35% <52.50%> (+0.24%) ⬆️
src/core/quote-check.js 61.82% <55.29%> (-7.99%) ⬇️
src/core/tn-links-check.js 69.06% <66.66%> (-0.28%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d544478...9140e00. Read the comment docs.

@RobH123 RobH123 changed the title Make updating of noticeList.txt more automatic Get annotation checks working, plus some small fixes Oct 13, 2020
@RobH123 RobH123 marked this pull request as ready for review October 13, 2020 07:23
@RobH123 RobH123 requested a review from PhotoNomad0 October 13, 2020 07:23
@RobH123 RobH123 requested a review from mandolyte October 14, 2020 06:47
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 28 of 28 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@mandolyte mandolyte merged commit c443305 into master Oct 16, 2020
@mandolyte mandolyte deleted the RJHimprovements branch October 16, 2020 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants