Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to checks #58

Merged
merged 4 commits into from
Oct 26, 2020
Merged

Small improvements to checks #58

merged 4 commits into from
Oct 26, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Oct 23, 2020

This change is Reviewable

@RobH123 RobH123 requested a review from PhotoNomad0 October 23, 2020 03:23
@RobH123
Copy link
Contributor Author

RobH123 commented Oct 23, 2020

Should also be ready to publish I think.

@codecov
Copy link

codecov bot commented Oct 23, 2020

Codecov Report

Merging #58 into master will decrease coverage by 0.04%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   46.18%   46.14%   -0.05%     
==========================================
  Files          20       20              
  Lines        2217     2241      +24     
  Branches      708      716       +8     
==========================================
+ Hits         1024     1034      +10     
- Misses        732      742      +10     
- Partials      461      465       +4     
Impacted Files Coverage Δ
src/core/annotation-row-check.js 1.92% <0.00%> (-0.02%) ⬇️
src/core/annotation-table-check.js 3.12% <14.28%> (-0.11%) ⬇️
src/core/tn-table-text-check.js 65.35% <14.28%> (-2.13%) ⬇️
src/core/field-text-check.js 55.81% <66.66%> (+1.11%) ⬆️
src/core/tn-table-row-check.js 70.81% <66.66%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9140e00...2152419. Read the comment docs.

@RobH123 RobH123 requested a review from mandolyte October 23, 2020 19:34
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1.
Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @mandolyte and @PhotoNomad0)

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 9 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @PhotoNomad0)

@mandolyte mandolyte merged commit bbba5f5 into master Oct 26, 2020
@mandolyte mandolyte deleted the RJHimprovements branch October 26, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants