Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v0.9.0 release #62

Merged
merged 8 commits into from
Nov 10, 2020
Merged

Prepare for v0.9.0 release #62

merged 8 commits into from
Nov 10, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Nov 9, 2020

Improved instructions in demos
Fixed failing assert
Added a couple more small checks.
Removed alpha from version number.


This change is Reviewable

@RobH123 RobH123 requested a review from mandolyte November 9, 2020 19:03
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #62 (898e9e4) into master (b600d85) will decrease coverage by 0.09%.
The diff coverage is 47.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   46.39%   46.30%   -0.10%     
==========================================
  Files          20       20              
  Lines        2444     2464      +20     
  Branches      789      800      +11     
==========================================
+ Hits         1134     1141       +7     
- Misses        818      825       +7     
- Partials      492      498       +6     
Impacted Files Coverage Δ
src/core/field-text-check.js 55.44% <41.93%> (-2.25%) ⬇️
src/core/tn-links-check.js 52.34% <100.00%> (ø)
src/core/usfm-text-check.js 58.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b600d85...898e9e4. Read the comment docs.

@RobH123 RobH123 changed the title Prepare for v0.8.17 release Prepare for v0.9.0 release Nov 10, 2020
@RobH123
Copy link
Contributor Author

RobH123 commented Nov 10, 2020

@mandolyte I feel that the last big PR, plus these small fixes and improvements are worthy for an advance to v0.9.0.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 13 files at r1, 14 of 14 files at r2, 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mandolyte mandolyte merged commit 4f0d3fa into master Nov 10, 2020
@mandolyte mandolyte deleted the RJHimprovements branch November 10, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants