Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start work on next version #64

Merged
merged 10 commits into from
Nov 22, 2020
Merged

Start work on next version #64

merged 10 commits into from
Nov 22, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Nov 11, 2020

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft November 11, 2020 04:00
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #64 (475c116) into master (898e9e4) will increase coverage by 0.19%.
The diff coverage is 49.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   46.30%   46.50%   +0.19%     
==========================================
  Files          20       21       +1     
  Lines        2464     2630     +166     
  Branches      800      837      +37     
==========================================
+ Hits         1141     1223      +82     
- Misses        825      884      +59     
- Partials      498      523      +25     
Impacted Files Coverage Δ
src/core/field-link-check.js 0.00% <0.00%> (ø)
src/core/manifest-text-check.js 8.51% <0.00%> (-0.19%) ⬇️
src/core/ta-reference-check.js 89.58% <ø> (ø)
src/core/usfm-js-check.js 11.76% <0.00%> (-4.91%) ⬇️
src/core/yaml-text-check.js 1.49% <4.16%> (-0.73%) ⬇️
src/core/getApi.js 10.71% <8.33%> (-1.13%) ⬇️
src/core/annotation-row-check.js 2.55% <9.52%> (+0.79%) ⬆️
src/core/annotation-table-check.js 2.30% <20.00%> (-0.06%) ⬇️
src/core/tn-links-check.js 52.74% <34.69%> (+0.40%) ⬆️
src/core/plain-text-check.js 58.76% <44.44%> (-16.54%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898e9e4...475c116. Read the comment docs.

@RobH123 RobH123 marked this pull request as ready for review November 20, 2020 08:59
@RobH123 RobH123 requested a review from mandolyte November 20, 2020 08:59
@RobH123
Copy link
Contributor Author

RobH123 commented Nov 20, 2020

@mandolyte Sorry it took so long to get this ready -- many distractions. Has disableAllLinkFetchingFlag now plus some improved checks after working with content team.

Doesn't yet handle checks of new file formats which Jesse wanted moved into branches, not in separate repos, but I don't think that's required quite yet anyway.

Also cutoffPriorityLevel is not yet moved from notice processing options into checkingOptions, but I think this PR is plenty big enough already.

Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; let me know when you next publish to NPM!

@mandolyte mandolyte merged commit dae2788 into master Nov 22, 2020
@mandolyte mandolyte deleted the RJHimprovements branch November 22, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants