Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next set of improvements #65

Merged
merged 7 commits into from
Nov 25, 2020
Merged

Next set of improvements #65

merged 7 commits into from
Nov 25, 2020

Conversation

RobH123
Copy link
Contributor

@RobH123 RobH123 commented Nov 22, 2020

This change is Reviewable

@RobH123 RobH123 marked this pull request as draft November 22, 2020 21:56
@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #65 (5a8adcc) into master (475c116) will decrease coverage by 0.54%.
The diff coverage is 22.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #65      +/-   ##
==========================================
- Coverage   46.50%   45.95%   -0.55%     
==========================================
  Files          21       21              
  Lines        2630     2681      +51     
  Branches      837      848      +11     
==========================================
+ Hits         1223     1232       +9     
- Misses        884      915      +31     
- Partials      523      534      +11     
Impacted Files Coverage Δ
src/core/annotation-row-check.js 2.55% <0.00%> (ø)
src/core/field-link-check.js 0.00% <0.00%> (ø)
src/core/getApi.js 10.71% <0.00%> (ø)
src/core/manifest-text-check.js 5.33% <0.00%> (-3.18%) ⬇️
src/core/tn-links-check.js 52.74% <0.00%> (ø)
src/core/markdown-text-check.js 74.72% <26.66%> (-8.82%) ⬇️
src/core/plain-text-check.js 58.76% <50.00%> (ø)
src/core/field-text-check.js 56.08% <53.57%> (+0.17%) ⬆️
src/core/markdown-file-contents-check.js 91.83% <100.00%> (ø)
src/core/text-handling-functions.js 92.85% <100.00%> (+0.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 475c116...5a8adcc. Read the comment docs.

@RobH123 RobH123 marked this pull request as ready for review November 25, 2020 03:18
@RobH123 RobH123 requested a review from mandolyte November 25, 2020 03:19
Copy link
Contributor

@mandolyte mandolyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 44 of 44 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mandolyte mandolyte merged commit 2566644 into master Nov 25, 2020
@mandolyte mandolyte deleted the RJHimprovements branch November 25, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants