Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds two test cases that fail #8

Merged

Conversation

richmahn
Copy link
Member

No description provided.

bookId: "1PE",
ref: "1:24",
quote:
"πᾶσα σὰρξ ὡς χόρτος, καὶ πᾶσα δόξα αὐτῆς ὡς ἄνθος χόρτου. ἐξηράνθη ὁ χόρτος, καὶ τὸ ἄνθος ἐξέπεσεν,",
Copy link
Member Author

@richmahn richmahn Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fails because of the period after χόρτου. If no period, or a new line is after the period, it will pass.

quote: "τῇ ἐκκλησίᾳ τοῦ Θεοῦ & τῇ οὔσῃ ἐν Κορίνθῳ",
occurrence: 1,
},
expected: "to the church of God that is in Corinth",
Copy link
Member Author

@richmahn richmahn Jan 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is returning to the church & that is in Corinth, leaving out of God and replacing it with &.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If occurrence is -1, which is the default for many test cases, it will return the expected string for some reason.

@abelpz abelpz merged commit 6ce4d68 into fix-not-found-quote-in-quote-combination Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants