Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow only specific columns in superset dataset #1567

Conversation

sheralim012
Copy link
Contributor

@sheralim012 sheralim012 commented Mar 7, 2023

Closes #1570

Only allow specific columns in the apache superset dataset.

@cbunicef
Copy link
Collaborator

cbunicef commented Mar 9, 2023

Thanks Sher. I think it's also good that we are specifically listing the columns, that will prevent any new columns being included automatically.

questionnaires/superset/datasets.py Outdated Show resolved Hide resolved
questionnaires/superset/utils.py Outdated Show resolved Hide resolved
@Alihassanc5
Copy link
Collaborator

@istride According to this a modification has been made to the API for creating virtual datasets and has been integrated, but the feature have not yet been released. We will update this accordingly after the release.

Copy link
Contributor

@istride istride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sheralim012 Eventually, it might be possible (and more Pythonic) to combine all the code in 'questionnaires/superset' into a single superset.py file and that is the direction I prefer to go in. For now, please move ALLOWED_COLUMNS from 'constants.py' to 'questionnaires/superset/__init__.py' and update the imports accordingly.

Feel free to merge once done.

@istride
Copy link
Contributor

istride commented Mar 28, 2023

...a modification has been made to the API for creating virtual datasets ... but the feature have not yet been released. We will update this accordingly after the release.

@Alihassanc5 sounds good. I'll leave it up to you to keep track of that and create an issue when it's time to update.

@sheralim012 sheralim012 merged commit cfded01 into unicef:develop Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow only specific columns in apache superset dataset
4 participants