Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material UI 5 + React 18 & other updates #152

Merged
merged 43 commits into from
Apr 8, 2024
Merged

Conversation

gauravr7
Copy link
Collaborator

@gauravr7 gauravr7 commented Mar 6, 2024

This code for material UI V4 will be maintain in branch v0.x
Thanks @vinuganesan for all the work that you did.

vinu.ganesan and others added 26 commits October 31, 2022 13:41
# Conflicts:
#	example/package-lock.json
#	example/src/components/Pickers.js
#	example/src/components/UConfirmationButtonExample.js
#	package-lock.json
#	package.json
#	src/components/ActiveKeyboardDatePicker/ActiveKeyboardDatePicker.js
#	src/components/ActiveKeyboardTimePicker/ActiveKeyboardTimePicker.js
#	src/components/UAsyncBadge/UAsyncBadge.js
#	src/components/UConfirmationButton/UConfirmationButton.js
#	src/components/UConfirmationButton/UConfirmationButton.md
#	src/components/UDatePicker/UDatePicker.js
#	src/components/UDateTimePicker/UDateTimePicker.js
#	src/components/UKeyboardDatePicker/UKeyboardDatePicker.js
#	src/components/UKeyboardDateTimePicker/UKeyboardDateTimePicker.js
#	src/components/UKeyboardTimePicker/UKeyboardTimePicker.js
#	src/components/USearchBox/USearchBox.js
#	src/components/USelectPicker/Control.js
#	src/components/USelectPicker/Menu.js
#	src/components/USelectPicker/NoOptionsMessage.js
#	src/components/USelectPicker/USelectPicker.js
#	src/components/UTextField/UTextField.js
#	src/components/UTimePicker/UTimePicker.js
#	styleguide.config.js
@gauravr7 gauravr7 self-assigned this Mar 6, 2024
package.json Outdated Show resolved Hide resolved
@vinuganesan
Copy link
Collaborator

@gauravr7 following validation is not working
image

package.json Show resolved Hide resolved
example/package.json Outdated Show resolved Hide resolved
example/package.json Outdated Show resolved Hide resolved
src/components/UAsyncBadge/UAsyncBadge.js Show resolved Hide resolved
src/components/UAvatarImage/UAvatarImage.js Outdated Show resolved Hide resolved
src/components/USelectPicker/SingleValue.js Outdated Show resolved Hide resolved
@vinuganesan vinuganesan self-requested a review March 15, 2024 10:48
@gauravr7
Copy link
Collaborator Author

gauravr7 commented Apr 2, 2024

The overall layout design have some styling glitches: image Content background is different, and top menu have different spacing

This has been fixed now

grathor and others added 4 commits April 2, 2024 16:32
@vinuganesan vinuganesan self-requested a review April 3, 2024 10:44
@vinuganesan
Copy link
Collaborator

Can you check the below warning?
image

@gauravr7
Copy link
Collaborator Author

gauravr7 commented Apr 3, 2024

In interactive-views page, I noticed that menuItems have some duplicated styles like 'display': image Is this. a configuration issue ? or a problem with mui5?

It is because of the vendor prefixes for css

@gauravr7
Copy link
Collaborator Author

gauravr7 commented Apr 8, 2024

Can you check the below warning? image

This is coming because react-select uses a different version of emotion css library

@vinuganesan vinuganesan requested a review from dfrancisc April 8, 2024 09:44
@vinuganesan vinuganesan self-requested a review April 8, 2024 09:45
@gauravr7 gauravr7 merged commit 7a4fb60 into master Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants