Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16346 Followup to PR 2731 #2743

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Feb 22, 2023

CLDR-16346

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true

"# coverageLevels.txt\n"
+ "# Copyright © 2022 Unicode, Inc.\n"
+ "# Copyright © 2023 Unicode, Inc.\n"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should use CldrUtililty.getCopyrightString("#") - maybe next time

@macchiati
Copy link
Member Author

I can't check in because of a bad commit message, and the usual "Details" fix doesn't work:

NOTICE: Your previous squash attempt failed with code 422. If you get this error repeatedly, you may not have permission to push to this repository.`

@srl295
Copy link
Member

srl295 commented Feb 27, 2023

I can't check in because of a bad commit message, and the usual "Details" fix doesn't work:

NOTICE: Your previous squash attempt failed with code 422. If you get this error repeatedly, you may not have permission to push to this repository.`

FYI @sffc what is this ?

Ok. You can disable the check. I'll dig out the info.

@srl295 srl295 self-assigned this Feb 27, 2023
srl295
srl295 previously approved these changes Feb 27, 2023
@srl295
Copy link
Member

srl295 commented Feb 27, 2023

Hmm. It didn't disable the validation message.

I get 404 trying to squash, can you try again?

@srl295
Copy link
Member

srl295 commented Feb 27, 2023

[X] Maintainers are allowed to edit this pull request.
If checked, users with write access to unicode-org/cldr can add new commits to your … branch. You can always change this setting later.

It looks like I'm NOT allowed to force push to your branch even though you checked this.

@macchiati
Copy link
Member Author

macchiati commented Feb 27, 2023 via email

@srl295 srl295 changed the title CLDR-16346 Followup to PR #2731 CLDR-16346 Followup to PR 2731 Feb 27, 2023
@srl295
Copy link
Member

srl295 commented Feb 27, 2023

@macchiati can you try it again now that i took the # out of the PR title

@srl295
Copy link
Member

srl295 commented Feb 27, 2023

unicode-org/jira-github-pr-check#28 referenced a 422 error when there was an emoji in the title

@srl295
Copy link
Member

srl295 commented Feb 27, 2023

CLDR-16346 had the title BRS v43 in Resolution+, Mark

I dropped the +, - @macchiati can you try the squash again?

@macchiati
Copy link
Member Author

macchiati commented Feb 27, 2023 via email

@srl295
Copy link
Member

srl295 commented Feb 27, 2023

I see that commit f2e0fe9 was updated correctly too.

@macchiati maybe after the TC call i can help you manually squash?

@macchiati
Copy link
Member Author

macchiati commented Feb 27, 2023 via email

@macchiati macchiati changed the base branch from main to maint/maint-43 February 27, 2023 20:12
@macchiati macchiati dismissed srl295’s stale review February 27, 2023 20:12

The base branch was changed.

@macchiati macchiati mentioned this pull request Feb 27, 2023
1 task
@srl295 srl295 closed this Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants