CLDR-16034 Check for pairing bidi markup chars (illegal); remove 2 (unpaired) RLO in ff_Adlm #3606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…npaired) RLO in ff_Adlm
macchiati
approved these changes
Apr 3, 2024
|
Thank you for fixing these. An automated testing tool I am using (rpminspect) was flagging these characters in OpenJDK's import of ff_Adlm.xml, and I was just about to ask a Unicode CLDR maintainer about them. While investigating this, I found two more RLO characters in common/annotationsDerived/ff_Adlm.xml, lines 93 and 94, which I suspect are also invalid: |
Those are actually generated from the display name for region "BW" which was fixed in this PR. So the next time the derived annotations are re-generated the problems in common/annotationsDerived/ff_Adlm.xml should go away. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-16034
Add test to check for bidi markup chars that are intended to be used in pairs; these are illegal in CLDR values )only LRM, RLM, ALM are ok). Then run the test to find any such issues; remove two (unpaired) RLO found in ff_Adlm.xml
ALLOW_MANY_COMMITS=true