CLDR-17514 Pages too big (v46): further divisions for Volume, Units #3614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't complete the ticket; there are more large pages to divide. Also, the names of the divided pages, and the criteria for dividing them, are open to improvement. I suggest we merge this PR anyway as another step in the right direction. |
srl295
requested changes
Apr 9, 2024
tools/cldr-code/src/main/java/org/unicode/cldr/util/PathHeader.java
Outdated
Show resolved
Hide resolved
-Divide Volume Other into Volume US and Volume Other -Divide Other Units into Other Units Metric, Other Units Metric Per, Other Units US and Other Units -New subroutines getOtherUnitsPageId, isSystemUnit, getShortUnitId -Fix deprecation warnings: remove getSectionsToPages; fix TestZ and filterCldr
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
srl295
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Divide Volume Other into Volume US and Volume Other
-Divide Other Units into Other Units Metric, Other Units Metric Per, Other Units US and Other Units
-New subroutines getOtherUnitsPageId, isSystemUnit, getShortUnitId
-Fix deprecation warnings: remove getSectionsToPages; fix TestZ and filterCldr
CLDR-17514
ALLOW_MANY_COMMITS=true