Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17566 Create downloads/cldr-45.md #3650

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Apr 21, 2024

CLDR-17566

Put together draft document for moving to markdown. This is a test run.

https://docs.google.com/document/d/1NoQX0zqSYqU4CUuNijTWKQaphE4SCuHl6Bej2C4mb58/edit

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati macchiati requested review from AEApple and srl295 April 21, 2024 00:02
@macchiati macchiati marked this pull request as ready for review April 22, 2024 16:16
@srl295
Copy link
Member

srl295 commented Apr 22, 2024

@lianghai any comments on the "Nav bar" item? could this be a job for Astro?


## [Known Issues](https://unicode-org.atlassian.net/issues/CLDR-17535?jql=project%20%3D%20cldr%20and%20labels%20%3D%20%22ReleaseKnownIssue%22%20and%20status%20!%3D%20done)

- [CLDR-17095](https://unicode-org.atlassian.net/browse/CLDR-17095). The region-based firstDay value (see [weekData](https://www.unicode.org/reports/tr35/tr35-72/tr35-dates.html#Week_Data)) is currently used for several different purposes. In the future, some of these functions will be separated out:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could probably linkify CLDR- keywords.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be handy.

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good!

@lianghai
Copy link
Member

@lianghai any comments on the "Nav bar" item? could this be a job for Astro?

Astro (see also Why Astro?) is a good choice if you want:

  • A full-on website architecture, optimized for static site generation but able to provide dynamic routes with a dynamic deployment.
  • Full-stack JavaScript/TypeScript.
  • Ability to use any mainstream component framework, from JSX and MDX to React, Vue, Svelte, etc.

A nav bar is so basic that any templating architecture can do. You guys already use Jekyll, which is probably fine for that.

@macchiati macchiati merged commit 2104fff into main Apr 23, 2024
11 checks passed
@macchiati
Copy link
Member Author

Liang, I'll file the comments on Astro as a separate ticket.

@macchiati macchiati deleted the CLDR-17566-Create-downloads/cldr-45.md branch April 23, 2024 20:24
@srl295
Copy link
Member

srl295 commented Apr 29, 2024

Shows up https://unicode-org.github.io/cldr/site/downloads/cldr-45.md but not wired into the HTML generation yet

@srl295
Copy link
Member

srl295 commented Apr 30, 2024

post script -
In #3660 i fixed the build, so that such .md files now show up

example https://unicode-org.github.io/cldr/site/downloads/cldr-45.html

enjoy and let me know if you see any issues.

@macchiati
Copy link
Member Author

macchiati commented Apr 30, 2024 via email

@macchiati
Copy link
Member Author

macchiati commented Apr 30, 2024 via email

@AEApple
Copy link
Contributor

AEApple commented May 1, 2024

Steven, that page https://unicode-org.github.io/cldr/site/downloads/cldr-45. html is no longer working.

weird, it's working for me

@srl295
Copy link
Member

srl295 commented May 1, 2024

Steven, that page https://unicode-org.github.io/cldr/site/downloads/cldr-45. html is no longer working.

weird, it's working for me

Works for me also

@macchiati
Copy link
Member Author

macchiati commented May 1, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants