Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17483 add Ladin (lld) variants #3656

Merged
merged 3 commits into from
Apr 26, 2024

Conversation

DavidLRowe
Copy link
Contributor

@DavidLRowe DavidLRowe commented Apr 26, 2024

CLDR-17483

  • This PR completes the ticket.

This PR and the previous PR (#3643) should complete the ticket. The previous PR added lld.xml and lld_IT.xml. This PR adds:
lld_ANPEZO.xml
lld_FASCIA.xml
lld_FODOM.xml
lld_GHERD.xml
lld_VALBADIA.xml
for the anpezo, fascia, fodom, gherd and valbadia variants. Note that the valbadia file has only the identity block, since this variant is used as the default for lld.

ALLOW_MANY_COMMITS=true

@DavidLRowe
Copy link
Contributor Author

@srl295 The build fails because the five variants aren't in common/validity/variant.xml, however the file says that the contents are generated and should not be manually updated. Reference is to GenerateValidityXML.java but what needs to change to cause that tool to add the variants to variant.xml?

@srl295
Copy link
Member

srl295 commented Apr 26, 2024

@srl295 The build fails because the five variants aren't in common/validity/variant.xml, however the file says that the contents are generated and should not be manually updated. Reference is to GenerateValidityXML.java but what needs to change to cause that tool to add the variants to variant.xml?

oh, are they in an update language subtag registry? perhaps that file needs a refresh.

@DavidLRowe DavidLRowe requested a review from srl295 April 26, 2024 05:13
@DavidLRowe
Copy link
Contributor Author

@srl295 I went ahead and added the 5 variant names to the generated data file. Hopefully you can figure out what changes are needed to get the file updated in the correct manner.

@srl295
Copy link
Member

srl295 commented Apr 26, 2024

@srl295 The build fails because the five variants aren't in common/validity/variant.xml, however the file says that the contents are generated and should not be manually updated. Reference is to GenerateValidityXML.java but what needs to change to cause that tool to add the variants to variant.xml?

oh, are they in an update language subtag registry? perhaps that file needs a refresh.

indeed https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry has an update that needs to be brought in.

@srl295
Copy link
Member

srl295 commented Apr 26, 2024

I'll update LST in https://unicode-org.atlassian.net/browse/CLDR-17585

@srl295
Copy link
Member

srl295 commented Apr 26, 2024

@DavidLRowe DavidLRowe merged commit 326a545 into unicode-org:main Apr 26, 2024
7 checks passed
@DavidLRowe DavidLRowe deleted the CLDR-17483a branch April 26, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants