CLDR-17459 Add units for grammar #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srl295
approved these changes
May 3, 2024
btangmu
approved these changes
May 3, 2024
| "dot-per-centimeter", | ||
| "millimeter-ofhg", | ||
| "milligram-ofglucose-per-deciliter"); | ||
| "point"); |
There was a problem hiding this comment.
if these were alphabetized this might be less confusing
|
The new text, except for point, all has comments, and ones with the same comments are (mostly) grouped together. I'm taking the 'point' back into the committee to see if that should be removed (where removal means we add grammar). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17459
Added grammar to some units that were skipped earlier.
The breakdown is at https://docs.google.com/spreadsheets/d/1soBtcb3SwNaCMg3maD0vvbWqqimco4ZKpdtSpB7NJ1E/edit#gid=0
Also
added a comparator for units, to help in examining the result. (And are needed for another ticket.)
set gasoline-per-mile to not be metric_adjacent
This PR completes the ticket.
ALLOW_MANY_COMMITS=true
DISABLE_JIRA_ISSUE_MATCH=true