-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17349 One-off import of emoji search keywords #3689
CLDR-17349 One-off import of emoji search keywords #3689
Conversation
Looks like some small errors: illegal character: common/annotations/ur.xml#L1Error: Bidi markup can only include LRM RLM ALM, not paired characters such as FSI PDIbuild: tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java#L927(TestTransforms.java:927) Error: Transliterator for Arab missing 2: [ٰؑ]=[\u0611\u0670] illegal character: common/annotations/ur.xml#L1 build: tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java#L927 |
I think we should go ahead and merge this. We can tweak thereafter, before Submission starts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spot check lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spot-checked the linguistic changes in a few locales and overall it looks good. Did not check the code changes since I can't really read code...
CLDR-17349
ALLOW_MANY_COMMITS=true