Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17349 One-off import of emoji search keywords #3689

Conversation

macchiati
Copy link
Member

CLDR-17349

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member Author

Looks like some small errors:

illegal character: common/annotations/ur.xml#L1Error: Bidi markup can only include LRM RLM ALM, not paired characters such as FSI PDI

build: tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java#L927(TestTransforms.java:927) Error: Transliterator for Arab missing 2: [ٰؑ]=[\u0611\u0670]

illegal character: common/annotations/ur.xml#L1
Error: Bidi markup can only include LRM RLM ALM, not paired characters such as FSI PDI
check

build: tools/cldr-code/src/test/java/org/unicode/cldr/unittest/TestTransforms.java#L927
(TestTransforms.java:927) Error: Transliterator for Arab missing 2: [ٰؑ]=[\u0611\u0670]

@macchiati macchiati marked this pull request as ready for review May 8, 2024 21:19
@macchiati
Copy link
Member Author

I think we should go ahead and merge this. We can tweak thereafter, before Submission starts.

@macchiati macchiati requested a review from stenshamn May 8, 2024 22:28
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spot check lgtm

Copy link
Contributor

@stenshamn stenshamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spot-checked the linguistic changes in a few locales and overall it looks good. Did not check the code changes since I can't really read code...

@macchiati macchiati merged commit af77ae6 into unicode-org:main May 9, 2024
10 checks passed
@macchiati macchiati deleted the CLDR-17349-One-off-import-of-emoji-search-keywords branch May 9, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants