-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17615 Update languages (v46 SBRS) #3700
Conversation
-So far I did the steps before this one: Run the tool CompareIso3166_1Status
FYI here is the output of the tool CompareIso3166_1Status which is part of the next step, not done yet:
|
Subtag: fascia | ||
Description: Fascia standard of Ladin | ||
Added: 2024-03-04 | ||
Prefix: lld | ||
Comments: Represents the standard written form of Ladin in Fascia which | ||
unified the three subvarieties Cazet, Brach and Moenat |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidLRowe FYI. this may be a factor in your other PR
I finished the dealing with the output of the tool CompareIso3166_1Status, and per my notes/screenshots in the ticket, it seems no further change is needed. I'm uncertain about the scope of "update langs" BRS task. So far I've followed the instructions up to but not including "Record the version: See Updating External Metadata" at https://cldr.unicode.org/development/updating-codes/update-languagescriptregion-subtags; am I done, other than making this draft PR ready for review? |
-GenerateValidityXML
-ignoreMissingAlpha3: EA, EZ, IC, UN per instructions
-ignoreMissingAlpha3: EA, EZ, IC, UN per instructions
GenerateEnums reports "Missing alpha3 for: CQ" GenerateEnums.java
Iso3166Data.java:
TestCoverageLevel.java:
|
OK my mistake, it is in 'REGION CODES NOT FOR TRANSLATION' so it's not simply at coverage=100 |
Complete output of GenerateEnums after making the changes in this PR:
|
Testing locally with "mvn test", there are some errors reported in the output, including the following, in spite of which the test ends with "SUCCESS" message:
|
@@ -79,6 +79,9 @@ public class GenerateEnums { | |||
|
|||
private Set<String> languages = new TreeSet<>(); | |||
|
|||
private final Set<String> ignoreMissingAlpha3 = | |||
new TreeSet<>(Arrays.asList("EA", "EZ", "IC", "UN")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More changes like this would belong in https://unicode-org.atlassian.net/browse/CLDR-17637
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks for doing these.
I think there may be tickets for the other errors you noted in the logs, not sure. the mysql one is not important here, but would be if there were automated tests for forums at that point.
The items that need fixes are like:
To fix: add to external/alternate_country_names.txt a line such as:
<code>; <name>; Latin America & the Caribbean (IDA & IBRD countries)
In the past, those have been fixed as part of the update. It involves
adding lines to external/alternate_country_names.txt of that form.
That file is used to interpret some external data files that don't use
country code.s
…On Wed, May 15, 2024 at 8:30 AM Steven R. Loomis ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM thanks for doing these.
I think there may be tickets for the other errors you noted in the logs,
not sure. the mysql one is not important here, but would be if there were
automated tests for forums at that point.
—
Reply to this email directly, view it on GitHub
<#3700 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMBMHYZKA4SIE247WZTZCN5R3AVCNFSM6AAAAABHNLKKVKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANJYGM3TAOBYG4>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
-Did all comprehensible/doable steps in https://cldr.unicode.org/development/updating-codes/update-languagescriptregion-subtags
-I'm unable to do this step: https://cldr.unicode.org/development/updating-codes/external-version-metadata
-Region code CQ may require further work
-Output of GenerateEnums and mvn test, after changes in this PR, is included in PR comments
CLDR-17615
ALLOW_MANY_COMMITS=true