Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17461 Forum posts in vetting view, change icon style #3723

Merged
merged 1 commit into from
May 15, 2024

Conversation

btangmu
Copy link
Member

@btangmu btangmu commented May 15, 2024

-Add margins and orange/green padding around 👁️‍🗨️/💬 icons, to make them easier to notice and distinguish

CLDR-17461

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

-Add margins and orange/green padding around 👁️‍🗨️/💬 icons, to make them easier to notice and distinguish
@btangmu btangmu self-assigned this May 15, 2024
@btangmu
Copy link
Member Author

btangmu commented May 15, 2024

image

@btangmu btangmu requested review from macchiati and AEApple May 15, 2024 16:30
Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These would definitely increase the visibility. I think the open forum posts are more interesting and need more highlight, so we might play a bit with the colors, but that can happen in a later PR.

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I noticed that the open/closed forum posts symbols show up even when not logged in. Not sure that's intentional, i can add a comment to the ticket if you want

@btangmu
Copy link
Member Author

btangmu commented May 15, 2024

even when not logged in

@srl295 there are comments about that in the ticket. I'm awaiting a decision whether the icons need to be hidden depending on user status (logged in? permission to view forum for the given locale?)

@btangmu btangmu merged commit 795135e into unicode-org:main May 15, 2024
11 checks passed
@btangmu btangmu deleted the t17461_e branch May 15, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants