Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17638 SBRS v46 CLDRModify passes before general submission #3724

Conversation

pedberg-icu
Copy link
Contributor

@pedberg-icu pedberg-icu commented May 15, 2024

CLDR-17638

  • This PR completes the ticket.

CLDRModfi passes before general submission. Each pass was handled as a separate commit whole should be preserved when merging.

  1. CLDRModify with no options; this did the following:
    • Reordered new units (speed-light-speed, concentr-portion-per-1e9, duration-night) to the end of each length group, instead of keeping them with their respective categories (this is likely due to missing/incorrect ordering data in DtdData or something)
    • Reordered exemplar entries
    • Reordered new annotation entries in root
    • Added some missing newlines at the ends of files
    • Updated headers as necessary (copyright etc)
  2. CLDRModify -fQ; this did the following:
    • Normalized annotations (reordered the keywords, eliminated case duplicates). However for locales in which such modified entries had status contributed or lower, it also removed the draft status (bad). So only the changes to en.xml were committed (since it has no draft entries).
  3. CLDRModify -fP (DAIP); this did the following:
    • Reformatted exemplars
    • Normalized annotations (reordered the keywords, eliminated case duplicates), duplicating what fQ is supposed to do, without removing the draft status (so the changes for all files were committed here). So that probably means -fQ is unnecessary.
    • Normalized apostrophes and hyphens, which did affect the en annotations

Note: This should be merged with a Rebase merge (temporarily enable in Settings), not a Squash merge.

ALLOW_MANY_COMMITS=true

…for en only (removes draft status for many others)
…alize annotations, normalize apostrophes/hyphens
@pedberg-icu pedberg-icu self-assigned this May 15, 2024
@pedberg-icu pedberg-icu merged commit dc7f411 into unicode-org:main May 15, 2024
7 checks passed
@pedberg-icu pedberg-icu deleted the CLDR-17638-SBRS-v46-CLDRModify-before-general-submission branch May 15, 2024 18:01
Copy link
Member

@btangmu btangmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spot-checked, LGTM. It often seems like some of these normalizations could be handled at earlier stages than CLDRModify and we'd benefit from less churn then...

@macchiati
Copy link
Member

We deliberately added emoji at the end, to make diff'ing easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants