Needs Clone: CLDR-17560 improve Dashboard robustness #3775
Conversation
- use second param to callback() to return err instead of global - popup err message if dashboard fails to load
| return; | ||
| } | ||
| this.locale = cldrStatus.getCurrentLocale(); | ||
| this.level = cldrCoverage.effectiveName(this.locale); | ||
| if (!this.locale || !this.level) { | ||
| this.fetchErr = "Please choose a locale and a coverage level first."; | ||
| this.fetchErr.value = | ||
| "Please choose a locale and a coverage level first."; |
There was a problem hiding this comment.
Does this work right in conjunction with <p v-if="fetchErr" class="st-sad">{{ fetchErr }}</p>?
In other words, will {{ fetchErr }} automatically show fetchErr.value?
There was a problem hiding this comment.
Maybe make fetchErr.value explicit where fetchErr is referenced near top of DashboardWidget.vue? And/or add a comment. We should test carefully after merging since there have been changes to these files in the meantime for virtual scroller; still it looks to me like they shouldn't be in conflict.
The change from created() to mounted() looks potentially important, I wonder if it might affect the "blinky" appearance we were discussing...
Right.
https://vuejs.org/guide/essentials/lifecycle.html actually, |
srl295
changed the title
CLDR-17560
ALLOW_MANY_COMMITS=true