Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDR-17703 Fix NPE in CodePointEscaper #3789

Merged
merged 1 commit into from
Jun 7, 2024
Merged

CLDR-17703 Fix NPE in CodePointEscaper #3789

merged 1 commit into from
Jun 7, 2024

Conversation

macchiati
Copy link
Member

CLDR-17703

  • Handle nulls in the CodePointEscaper

  • Add tests in UnicodeSetPrettyPrinterTest for edge cases.

    • Also fix the simple test to add more cases (setting locale, and setting the useRangesAbove.

  • Clean up SimpleUnicodeSetFormatter.java as well.

    • There were some test failures that led to cleaning up the handling of the default parameters.
    • Renamed some variables/constants for clarity

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati
Copy link
Member Author

Ping, I'd like to get this in.

@srl295
Copy link
Member

srl295 commented Jun 7, 2024

Merging since you said you'd like to get this in.

@srl295 srl295 merged commit 35acbba into unicode-org:main Jun 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@btangmu btangmu Awaiting requested review from btangmu

@DraganBesevic DraganBesevic Awaiting requested review from DraganBesevic

Assignees

@macchiati macchiati

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macchiati @srl295