Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17675 Revert change in en_ZA #3909

Merged

Conversation

macchiati
Copy link
Member

@macchiati macchiati commented Jul 26, 2024

New PR, replacing #3908

CLDR-17675

Revert the decimal/grouping change, but add alts to allow implementations to choose between official and us variant.

From the discussion in the Design meeting, we agreed on 2 variants, plus the default, as the normal pattern. That allows implementations to pick among the two choices by name — without having to know which was the default — or pick the default. People are also in favor of using semantic alt names, rather than just 'variant'.

Still draft because I want to pass this by the TC; there were a couple of things I wanted to get feedback on.

I think the decision was to go with the official syntax (12,34) for the default, but wanted feedback.
For the US style, I used alt="us", as probably the most recognizable term. But other suggestions are welcome. (Perhaps alt="period"?)

The ticket also mentioned R5,87 as the standard currency format, eg no space between currency alphabetics and the digits. That is in place also.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@macchiati macchiati force-pushed the CLDR-17675-Revert-change-in-en_ZA branch from 2e76041 to ed59451 Compare July 29, 2024 00:32
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@macchiati macchiati marked this pull request as ready for review July 29, 2024 00:52
@macchiati
Copy link
Member Author

Ping; I need approval for this after rebasing.

@macchiati macchiati merged commit 31cdf11 into unicode-org:main Jul 30, 2024
9 checks passed
@macchiati macchiati deleted the CLDR-17675-Revert-change-in-en_ZA branch July 30, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants