-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-17839 Fix units in he #3910
Conversation
@macchiati - Does short inherit from narrow instead of the other way around? I only changed 'narrow' to inherit, so I don't understand why we would require a value for two under narrow but not short? |
nm, maybe it's just due to a typo I had. |
You can get rid of some of the errors by rebasing onto main. I can help with the others on Monday. |
When you get back, can you rebase this on main? We can then take a look at why the other errors are happening. |
interestingly it only gave me the option to refresh with a merge commit and not rebase |
@macchiati - I think you have to fix the plurals issue first and then I should make my change on top of it. Right now I'm seeing errors due to items such as: https://st.unicode.org/cldr-apps/v#/he/Graphics/665721dc2c8221b3 which is unexpected since two is only used for two per the plural charts: https://www.unicode.org/cldr/charts/45/supplemental/language_plural_rules.html#he |
I'm not sure what is going on here. (Sorry I missed your message of 4 days ago.) I'll have to investigate tomorrow. Check failure on line 12161 in common/main/he.xml Very odd. The check appears to be malfunctioning, because ↑↑↑ is allowed everywhere inheritance is. Check failure on line 12487 in common/main/he.xml It is very strange because in many other cases "↑↑↑" works fine. |
da0b787
to
b85039d
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
Okay, well I went through and updated everything which seemed like it matched. There were a few things I was less sure about (e.g. durations). I sometimes had a more abbreviated value inherit where it seemed safer. |
Whew, a lot of work there! Approved |
I'm having people review in staging so that I can make any change if needed. I will merge before Dragan starts the alpha1 integration though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLDR-17839 Fix two in durations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLDR-17839 Fix two in durations
CLDR-17839 Update he narrow units to inherit from short See #3910
417063c
to
03ff4e5
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
CLDR-17839
Update he narrow units to inherit from short
ALLOW_MANY_COMMITS=true