Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17803 docs/site: fix merge to main #3996

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Aug 28, 2024

  • only update PR if there's a PR - correct an error on merge to main previously.

CLDR-17803

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@srl295 srl295 self-assigned this Aug 28, 2024
@srl295 srl295 force-pushed the cldr-17803/cloudflare-oops branch from e5ece18 to 2029b2f Compare August 28, 2024 19:26
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/site.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link

✨ deployed to https://9536ee10.cldr.pages.dev

@github-actions github-actions bot added the Site Update Updates docs/site label Aug 28, 2024
- only update PR if there's a PR
@srl295 srl295 force-pushed the cldr-17803/cloudflare-oops branch from 2029b2f to 2e06b87 Compare August 28, 2024 19:30
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/site.yml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link

✨ deployed to https://a6740a75.cldr.pages.dev

@srl295 srl295 requested review from macchiati and btangmu August 28, 2024 19:32
@srl295 srl295 marked this pull request as ready for review August 28, 2024 19:33
@macchiati
Copy link
Member

BTW, is there a way to skip the tests when the only change is to markdown files? That would speed up turnaround.

@srl295 srl295 merged commit bf0e159 into main Aug 28, 2024
14 checks passed
@srl295 srl295 deleted the cldr-17803/cloudflare-oops branch August 28, 2024 21:23
@srl295
Copy link
Member Author

srl295 commented Aug 28, 2024

BTW, is there a way to skip the tests when the only change is to markdown files? That would speed up turnaround.

i think i have another issue for that, but yes.

An issue is that the tests are 'required' so we need some way for them to appear as done, even if they are skipped, i think. Unless skipped counts as done, I could check that.

haytenf pushed a commit to haytenf/cldr that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Site Update Updates docs/site
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants