Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-13980 v46 ddl: Seed data for Kazakh (Arabic) #589

Merged
merged 1 commit into from
May 11, 2024
Merged

CLDR-13980 v46 ddl: Seed data for Kazakh (Arabic) #589

merged 1 commit into from
May 11, 2024

Conversation

MuratKaribay
Copy link
Contributor

@MuratKaribay MuratKaribay commented Jul 29, 2020

Checklist

New locale request for Kazakh (Arabic)

ALLOW_MANY_COMMITS=true

@MuratKaribay MuratKaribay changed the title Seed data for Kazakh (Arabic) CLDR-13980 Seed data for Kazakh (Arabic) Jul 29, 2020
@MuratKaribay
Copy link
Contributor Author

@srl295 please look at the request

Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • minimalPairs go under (submitted a requested change)
  • there's a kk_Arab in the exemplars/main directory. Please compare to that as well and delete it from your branch.
  • kk needs to be made multi script, so kk will need to change to be kk-Cyrl . This is more complex, and is why there are default content issues.
  • This also relates to the upcoming kk-Latn https://unicode-org.atlassian.net/browse/CLDR-10736

fyi @macchiati

seed/main/kk_Arab.xml Outdated Show resolved Hide resolved
seed/main/kk_Arab.xml Outdated Show resolved Hide resolved
@MuratKaribay
Copy link
Contributor Author

@srl295 For kk-Latn and changing kk in kk-Cyrl, do I need to create a new branch, or can I add in this branch?

@srl295
Copy link
Member

srl295 commented Jul 31, 2020

@srl295 For kk-Latn and changing kk in kk-Cyrl, do I need to create a new branch, or can I add in this branch?

There's no need to create a new branch. Actually, fix the suggestion I made above, and the rest will probably need to be discussed in committee

@MuratKaribay
Copy link
Contributor Author

There's no need to create a new branch. Actually, fix the suggestion I made above, and the rest will probably need to be discussed in committee

Please check

@CLAassistant
Copy link

CLAassistant commented Jul 31, 2020

CLA assistant check
All committers have signed the CLA.

@MuratKaribay
Copy link
Contributor Author

@srl295 now I need to merge all the commits into a single commit?

@MuratKaribay
Copy link
Contributor Author

MuratKaribay commented Aug 2, 2020

@srl295 can I add keyboard data, annotation, and romanization to this branch?
And you can find out when to add the kk_Arab locale and how long it will take?

@macchiati can I get permission to edit kk_Arab locale data in the Survey Tool?
I have a guest account.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@MuratKaribay
Copy link
Contributor Author

@srl295 please can you answer the questions listed above?

@MuratKaribay
Copy link
Contributor Author

  • minimalPairs go under (submitted a requested change)
  • there's a kk_Arab in the exemplars/main directory. Please compare to that as well and delete it from your branch.
  • kk needs to be made multi script, so kk will need to change to be kk-Cyrl . This is more complex, and is why there are default content issues.
  • This also relates to the upcoming kk-Latn https://unicode-org.atlassian.net/browse/CLDR-10736

@srl295 please can you check?

@srl295
Copy link
Member

srl295 commented Sep 2, 2020

@MuratKaribay I think this should be post 38. I think we need to look closely at the kk-Latn effect here - as we add kk-Arab, I think we should see if we can also add kk-Latn at the same time.

@srl295 srl295 self-assigned this Aug 4, 2021
@srl295
Copy link
Member

srl295 commented Aug 4, 2021

@MuratKaribay can you rebase?

@srl295
Copy link
Member

srl295 commented Aug 4, 2021

can I add keyboard data, annotation, and romanization to this branch?

make it separate.

@srl295
Copy link
Member

srl295 commented Jan 24, 2022

@MuratKaribay PR still needs rebase. Will move this to v42

@srl295
Copy link
Member

srl295 commented Jul 29, 2022

@MuratKaribai ping? can you rebase this?

@srl295
Copy link
Member

srl295 commented Aug 8, 2022

@MuratKaribai this will need to move to v43 if it isn't rebased in the next few days

@srl295
Copy link
Member

srl295 commented Nov 1, 2022

@MuratKaribai Closing this. Note that 'seed' is going away, so when you reopen this, just update common/main not seed/main.

@srl295 srl295 mentioned this pull request Nov 1, 2022
1 task
@srl295
Copy link
Member

srl295 commented Jun 7, 2023

@MuratKaribai can you rebase this into common/main?

@srl295 srl295 changed the base branch from main to ddl/v46 February 22, 2024 00:17
@srl295 srl295 requested review from srl295, DavidLRowe and a team February 22, 2024 00:29
@srl295
Copy link
Member

srl295 commented Feb 22, 2024

hi @MuratKaribai it's rebased, let's make it work!

@srl295 srl295 added the ddl DDL-SC specific work label Feb 22, 2024
@srl295 srl295 changed the title CLDR-13980 Seed data for Kazakh (Arabic) CLDR-13980 v46 ddl: Seed data for Kazakh (Arabic) Feb 22, 2024
srl295
srl295 previously approved these changes Feb 22, 2024
@srl295 srl295 changed the base branch from ddl/v46 to main May 8, 2024 22:02
@srl295 srl295 dismissed their stale review May 8, 2024 22:02

The base branch was changed.

srl295
srl295 previously approved these changes May 8, 2024
@DavidLRowe
Copy link
Contributor

Resolving a conflict in supplementalMetadata.xml resulted in a commit message which lacks the ticket number. This can be fixed by squashing the commits, but better to wait for other tests to pass first.

@DavidLRowe
Copy link
Contributor

@srl295 Seems to pass tests now, after I removed the empty auxiliary exemplar and resolved a conflict in supplementalMetadata.xml.

@srl295
Copy link
Member

srl295 commented May 11, 2024

Thanks… Looks like the merge commit had the wrong message though.

@MuratKaribai
can you squash again?

@srl295
Copy link
Member

srl295 commented May 11, 2024

Resolving a conflict in supplementalMetadata.xml resulted in a commit message which lacks the ticket number. This can be fixed by squashing the commits, but better to wait for other tests to pass first.

a1173e9 you can fix the commit message when doing the merge, but you only get one chance because we maintainers can only add commits not modify them…

@MuratKaribay
Copy link
Contributor Author

@srl295 could you please help me with squash, as I opened this PR 4 years ago and have forgotten a lot of things. Maybe I need to enter the data through Survey Tool so that I don't have any problems with PR

@srl295
Copy link
Member

srl295 commented May 11, 2024

@srl295 could you please help me with squash, as I opened this PR 4 years ago and have forgotten a lot of things. Maybe I need to enter the data through Survey Tool so that I don't have any problems with PR

We MUST get this PR in before we can enter data in the survey tool.

Please just go to https://us-central1-dev-infra-273822.cloudfunctions.net/unicode-github-bot/info/unicode-org/cldr/589 and check the box to authorize squashing the branch.

Then we can merge

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 merged commit 1ccf85c into unicode-org:main May 11, 2024
10 checks passed
@srl295
Copy link
Member

srl295 commented May 11, 2024

@MuratKaribai thank you for your patience ! Reply on the thread about the account, you should be able to get a kk-Arab account now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddl DDL-SC specific work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants