-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-13980 v46 ddl: Seed data for Kazakh (Arabic) #589
Conversation
@srl295 please look at the request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- minimalPairs go under (submitted a requested change)
- there's a
kk_Arab
in the exemplars/main directory. Please compare to that as well and delete it from your branch. - kk needs to be made multi script, so
kk
will need to change to bekk-Cyrl
. This is more complex, and is why there are default content issues. - This also relates to the upcoming
kk-Latn
https://unicode-org.atlassian.net/browse/CLDR-10736
fyi @macchiati
@srl295 For kk-Latn and changing kk in kk-Cyrl, do I need to create a new branch, or can I add in this branch? |
There's no need to create a new branch. Actually, fix the suggestion I made above, and the rest will probably need to be discussed in committee |
Please check |
@srl295 now I need to merge all the commits into a single commit? |
@srl295 can I add keyboard data, annotation, and romanization to this branch? @macchiati can I get permission to edit kk_Arab locale data in the Survey Tool? |
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
@srl295 please can you answer the questions listed above? |
@srl295 please can you check? |
@MuratKaribay I think this should be post 38. I think we need to look closely at the kk-Latn effect here - as we add kk-Arab, I think we should see if we can also add kk-Latn at the same time. |
@MuratKaribay can you rebase? |
make it separate. |
@MuratKaribay PR still needs rebase. Will move this to v42 |
@MuratKaribai ping? can you rebase this? |
@MuratKaribai this will need to move to v43 if it isn't rebased in the next few days |
@MuratKaribai Closing this. Note that 'seed' is going away, so when you reopen this, just update common/main not seed/main. |
@MuratKaribai can you rebase this into common/main? |
hi @MuratKaribai it's rebased, let's make it work! |
Resolving a conflict in supplementalMetadata.xml resulted in a commit message which lacks the ticket number. This can be fixed by squashing the commits, but better to wait for other tests to pass first. |
@srl295 Seems to pass tests now, after I removed the empty auxiliary exemplar and resolved a conflict in supplementalMetadata.xml. |
Thanks… Looks like the merge commit had the wrong message though. @MuratKaribai |
a1173e9 you can fix the commit message when doing the merge, but you only get one chance because we maintainers can only add commits not modify them… |
@srl295 could you please help me with squash, as I opened this PR 4 years ago and have forgotten a lot of things. Maybe I need to enter the data through Survey Tool so that I don't have any problems with PR |
We MUST get this PR in before we can enter data in the survey tool. Please just go to https://us-central1-dev-infra-273822.cloudfunctions.net/unicode-github-bot/info/unicode-org/cldr/589 and check the box to authorize squashing the branch. Then we can merge |
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
@MuratKaribai thank you for your patience ! Reply on the thread about the account, you should be able to get a kk-Arab account now. |
Checklist
New locale request for Kazakh (Arabic)
ALLOW_MANY_COMMITS=true