ICU-22818 Fix memory leak during error in messageformat2_data_model.cpp

See #3077
unicode-org · Aug 6, 2024 · 1eb0ed2 · 1eb0ed2
1 parent a22dc93
commit 1eb0ed2
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/icu4c/source/i18n/messageformat2_data_model.cpp b/icu4c/source/i18n/messageformat2_data_model.cpp
@@ -1091,13 +1091,13 @@ MFDataModel::MFDataModel(const MFDataModel::Builder& builder, UErrorCode& errorC
         U_ASSERT(builder.selectors != nullptr);
         int32_t numVariants = builder.variants->size();
         int32_t numSelectors = builder.selectors->size();
-        Variant* variants = copyVectorToArray<Variant>(*builder.variants, errorCode);
-        Expression* selectors = copyVectorToArray<Expression>(*builder.selectors, errorCode);
+        LocalArray<Variant> variants(copyVectorToArray<Variant>(*builder.variants, errorCode), errorCode);
+        LocalArray<Expression> selectors(copyVectorToArray<Expression>(*builder.selectors, errorCode), errorCode);
         if (U_FAILURE(errorCode)) {
             bogus = true;
             return;
         }
-        body.emplace<Matcher>(Matcher(selectors, numSelectors, variants, numVariants));
+        body.emplace<Matcher>(Matcher(selectors.orphan(), numSelectors, variants.orphan(), numVariants));
     }
 
     U_ASSERT(builder.bindings != nullptr);