ICU-20034 Locale assignment operator should set the locale to bogus if OOM occurs. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to "bogus" if an OOM error occurs when attempting to copy data over from the other locale.
srl295
previously approved these changes
Jul 19, 2018
jefgen
changed the title
sffc
referenced
this pull request
in sffc/icu
Sep 26, 2018
…ogus if OOM occurs. (#14) ICU-20034 ICU4C the Locale class's assignment operator should set the locale to "bogus" if an OOM error occurs when attempting to copy data over from the other locale. Also need to check strdup, as that calls malloc and it can fail too.
sffc
referenced
this pull request
in sffc/icu
Sep 26, 2018
…ogus if OOM occurs. (#14) ICU-20034 ICU4C the Locale class's assignment operator should set the locale to "bogus" if an OOM error occurs when attempting to copy data over from the other locale. Also need to check strdup, as that calls malloc and it can fail too.
sffc
referenced
this pull request
in sffc/icu
Sep 27, 2018
…ogus if OOM occurs. (#14) ICU-20034 ICU4C the Locale class's assignment operator should set the locale to "bogus" if an OOM error occurs when attempting to copy data over from the other locale. Also need to check strdup, as that calls malloc and it can fail too.
sffc
referenced
this pull request
in sffc/icu
Sep 27, 2018
…ogus if OOM occurs. (#14) ICU-20034 ICU4C the Locale class's assignment operator should set the locale to "bogus" if an OOM error occurs when attempting to copy data over from the other locale. Also need to check strdup, as that calls malloc and it can fail too.
sffc
referenced
this pull request
in sffc/icu
Sep 27, 2018
…ogus if OOM occurs. (#14) ICU-20034 ICU4C the Locale class's assignment operator should set the locale to "bogus" if an OOM error occurs when attempting to copy data over from the other locale. Also need to check strdup, as that calls malloc and it can fail too.
sffc
referenced
this pull request
in sffc/icu
Sep 27, 2018
…ogus if OOM occurs. (#14) ICU-20034 ICU4C the Locale class's assignment operator should set the locale to "bogus" if an OOM error occurs when attempting to copy data over from the other locale. Also need to check strdup, as that calls malloc and it can fail too.
5 tasks
younies
referenced
this pull request
in younies/icu
Feb 18, 2020
Some sample unitPreferences data for discussing output format.
hugovdm
added a commit
to hugovdm/icu
that referenced
this pull request
Mar 25, 2020
Comment out broken tests
GerHobbelt
pushed a commit
to GerHobbelt/icu
that referenced
this pull request
Mar 11, 2024
…code-org#14) Reverts 1b671c9 changes to umapfile.cpp because it begins using CreateFileW and MapViewOfFile. This commit causes a link error with UWP Debug builds only, due to duplicate symbols in SKIA, which also has an ICU build, and utilises these windows functions. Be sure to resolve this before moving forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Locale class assignment operator should set the locale to "bogus" if an out-of-memory (OOM) error occurs when attempting to copy data over from the other locale.