ICU-21581 integrate CLDR release-40-m1 to ICU trunk #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedberg-icu
requested review from
sffc,
yumaoka,
macchiati,
markusicu,
jefgen and
gnrunge
|
/azp run CI-Exhaustive |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pedberg-icu
force-pushed
the
ICU-21581-brs70rc-integrate-cldr-40-at-data-submit
branch
from
a003741 to
1949ff5
Compare
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
pedberg-icu
deleted the
ICU-21581-brs70rc-integrate-cldr-40-at-data-submit
branch
markusicu
requested changes
Jun 15, 2021
| @@ -11357,6 +11362,7 @@ supplementalData:table(nofallback){ | |||
| "energy-british-thermal-unit", | |||
| "force-pound-force", | |||
| "force-newton", | |||
| "force-kilowatt-hour-per-100-kilometer", | |||
There was a problem hiding this comment.
Huh? That's a measure of consumption, not of force.
There was a problem hiding this comment.
By definition, energy over distance equals force. So the "real" category should be force. But the "fake" category could still be consuption if that makes more sense.
There was a problem hiding this comment.
kWh/100km should go together with
"consumption-liter-per-100-kilometer",
"consumption-liter-per-kilometer",
"consumption-mile-per-gallon",
"consumption-mile-per-gallon-imperial",
There was a problem hiding this comment.
| @@ -422,6 +427,11 @@ en{ | |||
| } | |||
| } | |||
| force{ | |||
| kilowatt-hour-per-100-kilometer{ | |||
1 task
|
The prefix in the long cldr ID no longer has much meaning, and there is a
ticket to remove it (thus ending up just with the short cldrID.
It has been replaced at a lower level by the SI quantity. And the quantity
for kWh/100km is force.
cc @shane Carr ***@***.***>
…On Tue, Jun 15, 2021 at 2:31 PM Markus Scherer ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In icu4c/source/data/misc/supplementalData.txt
<#1742 (comment)>:
> @@ -11357,6 +11362,7 @@ supplementalData:table(nofallback){
"energy-british-thermal-unit",
"force-pound-force",
"force-newton",
+ "force-kilowatt-hour-per-100-kilometer",
Huh? That's a measure of consumption, not of force.
------------------------------
In icu4c/source/data/unit/en.txt
<#1742 (comment)>:
> @@ -422,6 +427,11 @@ en{
}
}
force{
+ kilowatt-hour-per-100-kilometer{
again, consumption not force
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1742 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMAJWRJQLU64VZWXGILTS7BBLANCNFSM46WWAD7Q>
.
|
|
In particular, the old prefixes are rubbish for conversion, since they
group unconvertable units together, and separate convertible units.
Mark
…On Tue, Jun 15, 2021 at 3:34 PM Markus Scherer ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In icu4c/source/data/misc/supplementalData.txt
<#1742 (comment)>:
> @@ -11357,6 +11362,7 @@ supplementalData:table(nofallback){
"energy-british-thermal-unit",
"force-pound-force",
"force-newton",
+ "force-kilowatt-hour-per-100-kilometer",
kWh/100km should go together with
"consumption-liter-per-100-kilometer",
"consumption-liter-per-kilometer",
"consumption-mile-per-gallon",
"consumption-mile-per-gallon-imperial",
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#1742 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACJLEMFYT4EDIQKMGBZRR33TS7IOJANCNFSM46WWAD7Q>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
This integrates into ICU the CLDR data in xml as of a few days after the start of data submission for CLDR 40; this is tagged CLDR "release-40-m1". This should have most or all of the new structure going into CLDR 40, but does not yet have any results of data submission and vetting via the CLDR Survey Tool.
Some notable items:
Note: in ICU-21569,
icu4c/source/data/brkitr/root.txtwas manually edited to addlstmentries without adding the corresponding source data inicu4c/source/data/xml/brkitr/root.xml, so the normal CLDR-ICU integration deletes them. In this PR thoselstmentries inicu4c/source/data/brkitr/root.txtare manually restored, but for the next CLDR-ICU integration,icu4c/source/data/xml/brkitr/root.xmlshould be updated to generate them automatically.