Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21694 ubidi.h sample code would not compile #1783

Merged
merged 1 commit into from
Aug 4, 2021
Merged

ICU-21694 ubidi.h sample code would not compile #1783

merged 1 commit into from
Aug 4, 2021

Conversation

litherum
Copy link
Contributor

@litherum litherum commented Jul 30, 2021 •
edited
Loading

  • [✅] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-21694
  • [✅] Required: The PR title must be prefixed with a JIRA Issue number.
  • [✅] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [✅] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [✅] Issue accepted (done by Technical Committee after discussion)
  • [✅] Tests included, if applicable (not applicable)
  • [✅] API docs and/or User Guide docs changed or added, if applicable

@CLAassistant
Copy link

CLAassistant commented Jul 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@pedberg-icu pedberg-icu self-requested a review August 4, 2021 18:13
@pedberg-icu pedberg-icu self-assigned this Aug 4, 2021
pedberg-icu
pedberg-icu approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@litherum litherum merged commit e2fafa5 into unicode-org:main Aug 4, 2021
@litherum litherum deleted the bidisamplecode branch June 21, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedberg-icu pedberg-icu pedberg-icu approved these changes

Assignees

@pedberg-icu pedberg-icu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litherum @CLAassistant @pedberg-icu