Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22220 Automate BRS tasks #2318

Merged
merged 1 commit into from
Feb 16, 2023
Merged

ICU-22220 Automate BRS tasks #2318

merged 1 commit into from
Feb 16, 2023

Conversation

echeran
Copy link
Contributor

@echeran echeran commented Feb 13, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22220
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

echeran added a commit to echeran/icu that referenced this pull request Feb 14, 2023
@echeran
ICU-22220 Automate BRS tasks
ce50896 
See unicode-org#2318
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@echeran echeran marked this pull request as ready for review February 14, 2023 21:24
@echeran echeran assigned markusicu and FrankYFTang and unassigned FrankYFTang Feb 14, 2023
echeran added a commit to echeran/icu that referenced this pull request Feb 15, 2023
@echeran
ICU-22220 Automate BRS tasks
f1e469b 
See unicode-org#2318
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

echeran added a commit to echeran/icu that referenced this pull request Feb 15, 2023
@echeran
ICU-22220 Automate BRS tasks
727b764 
See unicode-org#2318
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • docs/processes/release/tasks/healthy-code.md is now changed in the branch
  • docs/processes/release/tasks/integration.md is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu reviewed Feb 15, 2023
View reviewed changes
.github/workflows/icu_ci.yml Outdated
- name: Run make for stubdata, common, i18n
run: |
cd icu4c/source
pushd stubdata && make && popd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

totally optional: this is the same as (cd stubdata && make) right?

.github/workflows/icu_ci.yml Outdated Show resolved Hide resolved
docs/processes/release/tasks/integration.md Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • .github/workflows/icu_ci.yml is different
  • docs/processes/release/tasks/healthy-code.md is different
  • docs/processes/release/tasks/integration.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

markusicu
markusicu approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

@echeran echeran merged commit bd065d4 into unicode-org:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankYFTang FrankYFTang FrankYFTang left review comments

@markusicu markusicu markusicu approved these changes

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@echeran @markusicu @FrankYFTang