Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22309 update CONTRIBUTING.md for new process #2417

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Apr 10, 2023

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22309
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)

#2402 was the prior update to CONTRIBUTING.md
#2415 also see

CLA section from https://github.com/unicode-org/.github/blob/main/.github/CONTRIBUTING.md

fyi @annebright

@srl295 srl295 self-assigned this Apr 10, 2023
@srl295 srl295 force-pushed the srl295/icu-22309/contributing-deux branch from 5754ded to f198d16 Compare April 17, 2023 17:56
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 srl295 force-pushed the srl295/icu-22309/contributing-deux branch from f198d16 to d40e714 Compare April 17, 2023 17:59
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • CONTRIBUTING.md is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295
Copy link
Member Author

srl295 commented Apr 17, 2023

@markusicu ping ? required for new CLA process


## Process

See also [git for ICU Developers][git4icu].

If you want to join the team, then please contact us. Once everything is agreed, the ICU team adds you to the GitHub project and the Jira issue tracker.
If you want to join the team, then please [contact us][contacts]. Once everything is agreed, the ICU team adds you to the [GitHub project][unicode-org/icu] and the [Jira issue tracker][bugs].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like casual patches (without joining the team) got lost in the shuffle. I suggest we bring it back roughly here:

Suggested change
If you want to join the team, then please [contact us][contacts]. Once everything is agreed, the ICU team adds you to the [GitHub project][unicode-org/icu] and the [Jira issue tracker][bugs].
For patches, please submit both a Jira ticket and a GitHub pull request. See [Submitting ICU Bugs and Feature Requests][bugs].
If you want to join the team, then please [contact us][contacts]. Once everything is agreed, the ICU team adds you to the [GitHub project][unicode-org/icu] and the [Jira issue tracker][bugs].

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markusicu could we consider this in a separate PR? So that the wording for the already-installed CLA is in place first?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it could have been quick to amend the commit... but if you can remember to make another PR then that's ok.


## Process

See also [git for ICU Developers][git4icu].

If you want to join the team, then please contact us. Once everything is agreed, the ICU team adds you to the GitHub project and the Jira issue tracker.
If you want to join the team, then please [contact us][contacts]. Once everything is agreed, the ICU team adds you to the [GitHub project][unicode-org/icu] and the [Jira issue tracker][bugs].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it could have been quick to amend the commit... but if you can remember to make another PR then that's ok.

@srl295 srl295 merged commit ec3aef8 into unicode-org:main Apr 24, 2023
@srl295 srl295 deleted the srl295/icu-22309/contributing-deux branch April 24, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants