Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22433 uppercase decomposed greek to decomposed greek and precomposed greek to precomposed greek. #2522

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jul 5, 2023

Right now Greek uppercasing produces unnormalized text (it always introduces a precomposed dialytika, and always uses the decomposed eta tonos).

This change produces precomposed eta tonos from precomposed eta tonos, as was originally intended, and combining dialytika from combining accents on the preceding vowel; the test checks that NFD is mapped to NFD and NFC to NFC for all test strings.

The change also adds some tests for better coverage of the iota subscript behaviour.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22433
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/ucasemap.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/test/intltest/strcase.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@markusicu markusicu self-assigned this Jul 6, 2023
@markusicu markusicu requested a review from macchiati July 6, 2023 16:52
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@eggrobin eggrobin merged commit 47e47ec into unicode-org:main Aug 8, 2023
101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants