ICU-22434 Not calling setFirstDayOfWeek(MONDAY) if the locale has fw #2523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
pedberg-icu
previously approved these changes
Jul 6, 2023
The Calendar constructor already take care of the fw override. We should not set the first day of week for iso8601 to Monday if we have a fw keyword/type in the locale. ICU-22434 Fix incorrect calendar keyword extraction
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
pedberg-icu
approved these changes
Jul 7, 2023
|
@macchiati Mark - could you take a look at the unit test and approve if you think that is the right expected outcome for these cases. Thanks. |
macchiati
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Calendar constructor already take care of the fw override. We should not set the first day of week for iso8601 to Monday if we have a fw keyword/type in the locale.
Also fix a bug which caused by an incorrect calendar= keyword extraction code which cannot handle more than one keyword/type, by replacing the correct one from Locale class.
Checklist