Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22304 Miscellanous PersonNameFormatter fixes; made ExhaustivePers… #2528

Merged

Conversation

richgillam
Copy link
Contributor

@richgillam richgillam commented Jul 19, 2023

…onNameFormatterTest into a real unit test.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22304
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

Copy link
Contributor

@pedberg-icu pedberg-icu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool test features I did not know about!

@richgillam richgillam merged commit 85e75ec into unicode-org:main Jul 20, 2023
101 checks passed
@richgillam richgillam deleted the ICU-22304-personname-loose-ends branch July 20, 2023 17:52
@FrankYFTang
Copy link
Contributor

I belive the landing of this PR break the test
See the post merge report on https://github.com/unicode-org/icu/runs/15214572341
from https://github.com/unicode-org/icu/commits/main

The failure is

"
[junit] Running com.ibm.icu.dev.test.format.ExhaustivePersonNameFormatterTest
[junit] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.012 sec
"

@richgillam
Copy link
Contributor Author

richgillam commented Jul 28, 2023

@pedberg-icu has a couple pull requests pending that should fix this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants