Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22479 Add a new fuzzer to test more Locale methods #2576

Merged
merged 1 commit into from
Sep 5, 2023
Merged

ICU-22479 Add a new fuzzer to test more Locale methods #2576

merged 1 commit into from
Sep 5, 2023

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Sep 1, 2023 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22479
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@FrankYFTang
Copy link
Contributor Author

PTAL

markusicu
markusicu reviewed Sep 1, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly lgtm; please fix the indentation and then squash

icu4c/source/test/fuzzer/locale_morph_fuzzer.cpp Outdated Show resolved Hide resolved
@markusicu markusicu self-assigned this Sep 1, 2023
@FrankYFTang
Copy link
Contributor Author

PTAL

markusicu
markusicu reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm please squash

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@FrankYFTang FrankYFTang merged commit aa70ba6 into unicode-org:main Sep 5, 2023
103 of 104 checks passed
@FrankYFTang FrankYFTang deleted the ICU-22479-FuzzerULocale branch September 5, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@richgillam richgillam Awaiting requested review from richgillam

@younies younies Awaiting requested review from younies

Assignees

@markusicu markusicu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankYFTang @markusicu