-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ICU-22549 Add fuzzer for NumberFormatter #2706
ICU-22549 Add fuzzer for NumberFormatter #2706
Conversation
34ee3e3
to
e86f59f
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks okay to me, I think, but I'd like @sffc or somebody else more familiar with NumberFormatter
to weigh in on whether there are additional APIs on this class you should be fuzzing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: take 4 bytes of the input and make them into a floating point number to be formatted. Parsing the skeleton is good, but we can also cover data loading. However, doing so will make the fuzzer a bit slower.
e86f59f
to
2ac698f
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
I implemented it now. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Hopefully Shane does too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks right; it's possible I missed something in all the pointer math
Checklist