Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICU-22561 Added maven-gpg-plugin in pom.xml to sign artifacts for mav… #2716

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

yumaoka
Copy link
Member

@yumaoka yumaoka commented Dec 1, 2023

…en central release.

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22561
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@yumaoka
Copy link
Member Author

yumaoka commented Dec 1, 2023

This updated pom.xml was actually used for 74.1 release. Because repo was already tagged at that time, I merged the change to main branch at that time. For 74.2 maintenance update, we need this one merged to maint-74 branch as discussed in 2023-11-30 ICU-TC meeting.

Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please retarget this cherry-pick PR to maint/maint-74.

Given that it currently targets main, how is it possible that it shows the same change as in PR #2693 which you merged into main??

Did you follow the instructions or do something equivalent?

@mihnita
Copy link
Contributor

mihnita commented Dec 4, 2023

Yes, main contains this already: https://github.com/unicode-org/icu/blob/main/icu4j/pom.xml#L484

@yumaoka yumaoka changed the base branch from main to maint/maint-74 December 4, 2023 17:31
@yumaoka
Copy link
Member Author

yumaoka commented Dec 4, 2023

@markusicu @mihnita My mistake. Retargetted to maint-74.

@yumaoka yumaoka requested a review from markusicu December 4, 2023 17:32
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm tnx

@yumaoka yumaoka merged commit dd4c5f3 into unicode-org:maint/maint-74 Dec 5, 2023
52 checks passed
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
LGTM (but for some reason)

For some reason I don't get the buttons to approve.
So consider this an approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants