Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22583 BRS74: Version number update for 74.2 #2728

Closed
wants to merge 3 commits into from
Closed

ICU-22583 BRS74: Version number update for 74.2 #2728

wants to merge 3 commits into from

Conversation

rp9-next
Copy link
Contributor

@rp9-next rp9-next commented Dec 7, 2023 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22583
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@rp9-next rp9-next marked this pull request as ready for review December 7, 2023 14:57
markusicu
markusicu previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm tnx!

icu4j/releases_tools/shared.sh
Comment on lines +8 to +9
export artifact_version='74.2'
export github_rel_version='74_2'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: looks like we had missed updating these for 74.1 :-(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal.
That's a script I prepared to build and zip all the release files, including zipped complete javadoc and all.
But the release was done by Yoshito "by hand"

@markusicu markusicu mentioned this pull request Dec 7, 2023
Merged
7 tasks
@markusicu
Copy link
Member

@rp9-next Please resolve the merge conflict; I can then re-approve.

@markusicu
Copy link
Member

@rp9-next Please resolve the merge conflict; I can then re-approve.

The conflict is in .../icuver.txt, so the Java .../icudt74b/icuver.res will need to be updated too.
FYI @mihnita

mihnita
mihnita previously approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@mihnita mihnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, lgtm

@mihnita mihnita dismissed stale reviews from markusicu and themself via a20aa2e December 8, 2023 22:34
echeran
echeran approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@echeran echeran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

markusicu
markusicu requested changes Dec 9, 2023
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating icuver.txt, but as I said before, that's incomplete without also updating the corresponding icuver.res in the Java tree.

@markusicu markusicu mentioned this pull request Dec 9, 2023
Merged
7 tasks
@mihnita
Copy link
Contributor

mihnita commented Dec 9, 2023

Submitted as PR #2734

@mihnita mihnita closed this Dec 9, 2023
@rp9-next rp9-next deleted the brs_74.2_versionUpdate branch September 6, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu requested changes

@echeran echeran echeran approved these changes

@mihnita mihnita mihnita left review comments

Assignees

@echeran echeran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rp9-next @markusicu @mihnita @echeran